Abdullah Nassif• 405
@AbNassif
Posted
Great work!
0
Design comparison
Solution retrospective
The only thing I find weird is the box shadow settings that were in sketch file but hopefully everything is like it should be
Community feedback
karenefereyan• 375
@karenefereyan
Posted
I love it
1
Hello, Patrick! 👋
Firstly, congratulations on becoming mentor of the week! Your solution looks very good and also responds well. Here's my few tips:
- Change the
altattributes for the.usersavatars, as they don't add any extra context for screen reader users. Since your images are decorative youralttext should be provided empty (alt="") so that they can be ignored by assistive technologies. Informations provided by.nameand.graduateperfectly describe it itself. - Don't use ID selector to style every your section card, instead use class for it. IDs have a downside: they are completely unique and therefore cannot be reused. You could potentially style every element on your page with an ID selector but you would lose a lot of the benefit of CSS in the process. And later on if you ever want that styles to be override with another class for example it won't be possible due to specificity.
Good luck with that, have fun coding! 💪
1
@tediko Thanks, if I helped anyone that last week that is all that matters. I know I worked on these projects multiple times 9+ months before I started uploading any of them and still end up re doing them multiple times
I will keep in mind the screen reader issues and I know I need to study the whole accessibility thing with the changes to EU laws
I did mix classes with my IDs but I have been giving things IDs even if I do not style with them to keep the code my head better. I know I am creating global Dom objects but with practice projects I am not worried about having IDs on most elements at this point. But every challenge I seem to do a little different so we will see what I end up with long term
0
Paschal Maximillian• 185
@Pascal488
Posted
Hey bro congrats i've checked all of your projects and end up appreciating your effort big up bro,i wish we could be friends here is my Whatsapp number ping me if want +255789310923
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord