Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Testimonials grid using SCSS and BEM

#bem#sass/scss

@jaycgreenwald

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Thanks in advance for the feedback. I'm getting better at this in large part to all of the wonderful help I receive with each project.

Here are a few questions that came to mind:

  1. I used multiple scss files for really the first time. I would love to receive some feedback about how that went. Other ways to approach it and so on. (I kind of did what "felt natural" in this case. For a larger project, I imagine I might divide the css differently.)
  2. Is there ever a time I would use px instead of rem for the unit? The only thing I could think of is when I set the html font size. (In this project it was 13px.) Should I just keep using rem to my heart's content?

Please let me know about anything you think I can improve upon - BEM, accessibility, anything really. Thanks in advance for the help!

Community feedback

@Shard-Codes

Posted

Hello Jason, You did an excellent job on the challenge!

I think you did better than me, Honestly.

And yes you should use rem to your heart's content, Because it's the right way to go in terms of typography. It's the best practice.

As for your second question it's okay to use px at times maybe for like border-radius, box-shadow, border, and etc.

Everything else is perfect. Happy coding, Regards.

Marked as helpful

1

@jaycgreenwald

Posted

@Shard-Codes Thank you for the feedback! It is much appreciated. Happy coding indeed. Cheers!

0

@Shard-Codes

Posted

@jaycgreenwald Your welcome, Glad I could help.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord