@axseinga
Posted
Hi ellienndea,
Congrats on finishing this challenge!
Here are some suggestions from me:
- you can center your calculator vertically on the desktop design, so it does not stick to the bottom of the page,
- I would make the "coded by" paragraph much smaller, it looks really big on the desktop and it breaks into two lines on the mobile,
- you can change the event of event listener to "input" instead of "change" as it was suggested to me as well (I used originally "keyup"). With the "change" your event fires only when User clicks outside after filling the inputs,
- you can try to break your javascript code into smaller functions so it's more readable :) article about good practices in JS
I hope it will be helpful for you :) It's not so easy challenge. Great work!
Marked as helpful
@ellienndea
Posted
@axseinga Hi, thank you so much for your elaborate feedback. Those are all very good points and I will work through them while improving my code for the tip calculator. Happy coding! 😊