used html and css

Solution retrospective
hello, i am a newbie, please review my code and give feedback and advice. thanks.
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@makogeboris
Great job completing your first challenge, here are some suggestions
- The link to the github repo isn't working, you might want to check that
- You don't need the .container-outer delete that, just the .container is sufficient and wrap a
main
tag around the .container - Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use
max-width
ormin-height
, and prefer relative units likerem
for better adaptability. Change thewidth
of the .container tomax-width
and it should be defined inrem
. Also, remove theheight
property completely. - Give the .container a
padding: 2rem;
- To properly center the card, using flexbox on the body is better suited add this on your
body
display: flex; align-items: center; justify-content: center; min-height: 100dvh; background-color: hsl(0, 0%, 8%); padding: 1.5rem;
- Change the
width
of the .box to100%
and remove theheight
and usepadding
instead to determine it's size - Don't wrap text in empty divs, The .name is a heading element could be an
h2
and the .nation is ap
- Wrap the links in
a
tags
Hope this helps, Good luck!
Marked as helpful - @bhuvi819381
I'm unable to see your code
Your solution is looking good anyway
Keep up the good work 👍
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord