Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

using flexbox

esraagamal 600

@EsraaGamal-22


Design comparison


SolutionDesign

Solution retrospective


Rate my design please, Any feedback and suggestions on how I can improve are very welcome!

Community feedback

@Hatamovich

Posted

Hello Esra Gamal 😊 I would recommend you to wrap your content inside a container and center it and also always consider adding cursor: pointer; to you buttons. I also highly recommend you to use meaningful class names. try not to use names like "cont-1, cont-2, cont-1-2 , cont-2-2".

If you do not know what that container (wrapper) does then I strongly recommend you to go and do some research and learn how to center your content on the page, and learn why and how to use percentage units :)

http://css-tricks.com is a nice place to learn some cool and useful stuff.

Sorry for my English if you find it terrible :D I hope my advice will help you to get more comfortable 😊

1

esraagamal 600

@EsraaGamal-22

Posted

@Hatamovich i'm already using container which contain the main parts of my project then inside it i'm center these main parts.

0
Roman Filenko 3,335

@rfilenko

Posted

Hey, optimize it for mobile too, there are some issues with the responsiveness, probably images sizes or flex properties.

Roman

0

@kdumagalhaes

Posted

Hey!

I would add some details like cursor pointer when hovering the buttons and use a (link) instead of p (paragraphs) on footer links and stuff.

But I think it's really good! Congrats! :)

0

esraagamal 600

@EsraaGamal-22

Posted

@kdumagalhaes Thanks alot for your review. I'm already edited my code to add these details

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord