Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 2 years ago

Using Grid and padding

Malekos74•120
@Malekos74
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello everyone :D I am back at it with another challenge. Can someone please tell me why the background image on the page look goofy? I couldn't get them to align like in the preview images. Thanks in advance.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted about 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    BACKGROUND iMAGE 📸:

    • let me explain how you can easily apply the background color along with the background svg they provided.

    • Add the following style rule to your css, and then experience the changes
    body {
      background: url(./images/bg-pattern-top.svg), url(./images/bg-pattern-bottom.svg);
      background-position: right 52vw bottom 35vh, left 48vw top 52vh;
      background-repeat: no-repeat, no-repeat;
      background-color: hsl(185deg, 75%, 39%);
    }
    
    • Tip, Don't forget to generate a new screenshot after editing the css file

    HEADINGS ⚠️:


    • This solution has also generated accessibility error report due to lack of level-one heading <h1>

    • Every site must want at least one h1 element identifying and describing the main content of the page.

    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

  • Riki Wendri•1,380
    @F4YY
    Posted about 2 years ago

    Hello @Malekos74,

    Congratulations on successfully completing the challenge. you did very well.

    I have a recommendation that might interest you regarding setting the background position that will resemble like as much as the preview. Normally we can use a set of keywords like right, left, top, down, or center to place the image at the right, left, top, down, or center of the tag.

    However if it is still not appropriate we can set it manually. We use in the background-position property to do this. The selector takes in two values. The first one is for the horizontal position, or x-direction (how far across the tag). The second one is for the vertical position, or y-direction (how far down the tag).

    The values can be units, like a pair of pixels, eg:

         background-position: 20px 30px;
    

    This will move the image 20px across and 30px down the containing tag.

    or for 2 background images:

        background-position: top -150px left -150px, bottom -200px right -200px;
    

    To position an image with finer detail, it is worth mentioning that we can use percentages, eg:

        background-position: 20% 40%;
    

    This positions the image 20% across the tag and 40% down the tag.

    Hope that would be helpful. Keep happy coding..

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub