Using html file, css file and class to make the file

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted almost 3 years ago

  Hello , You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove height, max-inline-size, block-size and max-width from img tag and add width: 100% and border-radius: .5rem
  • remove all margin from main class
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh and margin: 0 to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  00

  Marked as helpful
• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hi @Lucas760, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

  Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings. The background-color in this case is background-color: #D5E1EF

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  00

  Marked as helpful
• Account deletedPosted almost 3 years ago

  Hey @Lucas760, some suggestions to improve you code:

  • The reason you having those issues, its because you used the incorrect properties to style you card. It needs to be responsive.

  This link from Google Developers will teach you how to make you content responsive.

  https://web.dev/learn/design/

  • To make your image responsive, it should have this:

  img {
    max-inline-size: 100%;
    block-size: auto;
  }
  

  • The Main Class width has to max-width.

  • Delete the width from the Text Class.

  Happy Coding!

  00

  Marked as helpful