Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Vanilla JavaScript, Components

RaulTC 260

@Raul-TC

Desktop design screenshot for the E-commerce product page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone, I leave you my solution to this challenge, I will make any suggestion.💻🤖

Community feedback

P
Chamu 12,970

@ChamuMutezva

Posted

Greetings Raul-TC , so far so good.

  • You did a great job. The display generally looks good .
  1. at about 375px and below, the site looks good and it is scaling well
  2. take a look at about 429px, your site breaks, with the header touching the edges of the browser and the main image just being a very tiny invisible image as well as the other thumbnail images. It starts to look better at about 750px, but will need to be centered to look much better. The header still needs attention so as not to touch the edges as shown in the design. The counter-container does needs some attention as well between 429px and 1307px.
  • i would not advice to set a width or max-width on the body element , it is the viewport and that should be as wide as it should be. However you can set that on container element that will be the only direct child of the body element. Setting a min-height on the body element with the following statement min-height: 100vh; is another method that is widely used.
  • on small devices, there is the left and right button which are not reflected by your design.
  • you did well with the logic part, the implementations are working as expected.
1

RaulTC 260

@Raul-TC

Posted

@ChamuMutezva hey, thanks for the comments, the page was only made for desktop and mobile, I will implement it soon.💻

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord