Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Visual studio code, Grid, keydown, click.

Khaled 60

@TunUnpred

Desktop design screenshot for the Calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
3intermediate
View challenge

Design comparison


SolutionDesign

Solution retrospective


I haven't started switching themes yet. I don't think your feedback takes that into account, thanks.

Community feedback

P
Matt Studdert 13,611

@mattstuddert

Posted

Hey Khaled, nice work. The main thing I'd recommend working on with this project would be to make it accessible. At the moment, you're using div elements instead of buttons for the keys. div elements aren't interactive and so can't be accessed by people not using a mouse/trackpad to click on the keys. Always be sure to use interactive elements if you expect the user to interact with the page.

Also, you're not using any of the technologies you've added as tags. I'd recommend removing the tags so that they match up with what you've used to build the project.

Keep it up!

Marked as helpful

0

Khaled 60

@TunUnpred

Posted

@mattstuddert Thanks for your time Matt, all buttons are now interactive and there are no unused tags.

0
P
Matt Studdert 13,611

@mattstuddert

Posted

@TunUnpred, you're welcome. Nice work! That's functioning much better now 👍

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord