Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 5 years ago

Vue.js REST axios with dark mode

Daniel Gibson•885
@DanielGibsonOrchid
A solution to the REST Countries API with color theme switcher challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Had great fun working on this project. Took a long time and learnt a lot during the process.

Challenges included:

  • Sending a second API request for the border countries after first API request had finished
  • Dark mode theme switcher
  • Search bar to automatically update content
  • Dropdown filter CSS to match design
  • Back button based on user history
  • Loading animation before API request completes

Very happy with the way it turned out. If you got a few minutes then please check it out and let me know if you have any feedback.

I'll appreciate feedback on best practices for CSS, HTML, Vue.js

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Matt Studdert•13,611
    @mattstuddert
    Posted over 5 years ago

    Hey Daniel, I'm glad you enjoyed this challenge! You've done a really good job getting everything working nicely. Here are a few pointers after taking a look at your code:

    • For the region filter, you're currently hardcoding each item. Another approach would be to have an array of the regions ['Africa', 'Americas', 'Asia', 'Europe', 'Oceania'] and then iterate over it to generate the items. This would reduce your code quite a bit.
    • Also, I'd recommend breaking out your code into smaller components. This makes the code much more manageable and maintainable.
    • For your CSS breakpoints, you're currently using max-width media queries. For a future project, I'd recommend having a go at using min-width as it means mobile users load in fewer styles.

    I hope these tips help. Let me know if you have any more questions! 🙂

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub