Ebuka Ejiofor• 20
@ebukathedev
Submitted
How do you suggest is a better way to place the image in it's container?
2div
@2div
All comments
- 2div• 170
@2div
Posted
Hi Ebuka, congratulation completing the challenge, you design look very close to solution design. To fix the accessibility issue in your report wrap your code inside main tag , you can write it like
<main class="container"> </main> over all you did well.1 - Kevin Douglas• 220
@qu3bin
Submitted
2div• 170@2div
Posted
Hi Kevin congratulation completing the challenge ,your design is very close to the main design.
You have an issue with box size because i click to view the live website the "cancel order button" is not appearing on the website. you need to check your box size for large screen and mobile screen too.
1 - Andrew Fernandes• 30
@andrew8gmf
Submitted
2div• 170@2div
Posted
Hi Your design look fine but you need to improve accessibility by wrapping your code in main tag ex : <main class="container">. Also add h1 tag.
You need to add overly to the main image , its a part of the design requirement.
I never used Angular and did not find your CSS file but above tips will solve the accessibility issues in your report.
Marked as helpful
1 - Stephanie Ezinne• 140
@stephanniegb
Submitted
feedback is welcome is there a better way I could have done this? especially for gapping the items in the flexbox
2div• 170@2div
Posted
Hello Stephanie First of all congratulation on completing this challenge and your solution is very good. below are my tips for improvement :
- Fix the a accessibility issue by change h2 to h1
- Also you need to increase the border radius for the box and the button
- You need to check the size for mobile screen because card look large.
over all you did great.
Marked as helpful
0 - Ashikodi Emeka• 30
@ashikodes
Submitted
2div• 170@2div
Posted
Hi Ashikod, i tried to open your code link but link is broken and not working. Make sure to write your correct github repo link.
0 - Sarad• 10
@s4rad
Submitted
Here I submit my solution for the QR Code Component Challenge. I would appreciate feedback on how I can approach designs in a mobile-first workflow.
2div• 170@2div
Posted
Hi Sarad ,
I see you use Bootstrap class that's great and advance than my code which is simple html/css your code is good too... congratulation completing the challenge.
0 - Nathalia Santos• 30
@naathcs
Submitted
Any feedback on CSS and HTML structure is welcome. I'm trying to improve both so I can start using libraries and also Javascript.
2div• 170@2div
Posted
Hi Nathalia, Congratulation completing the challenge. Your code is very good.
Marked as helpful
0 - Amber Upshaw• 20
@AmberUpshaw
Submitted
I'm aware that there's no mobile version, would like some assistance setting that up for the future.
2div• 170@2div
Posted
Hi Amber,
Congratulation completing the challenge. Please find my tips below :
1- I suggest you to change <div id="main"> to <main class="container"> </main>
2- Yon need to add alt attribute to img tags in index.html atl attribute is used to provide information about images like what is the image about, image author, etc.Your tag should be like this <img src="images/image-qr-code.png" alt="QR-Code">
3- change <div id="caption"> to <div class="text-content">
4- Change the h5 to h1
Marked as helpful
0 - ahmed-dev-code• 10
@Ahmed-dev-code
Submitted
here is my QR component challenge, i have some problems to make it more responisve
2div• 170@2div
Posted
Hi Ahmed, First congratulation completing the challenge. Kindly check your GitHub repo code link because its not working when i clicked to access your code on GitHub repo.
Marked as helpful
1 - William Larry• 70
@Willarry
Submitted
2div• 170@2div
Posted
Hi William,
Congratulation finishing the challenge. Below are tips :
1- change <div class="container"> to <main class="container"> </main> 2-change <div class="attribution"> to <footer> </footer>
0
