All comments

• 

  leviathan• 10

  @webdevleviathan

  Submitted over 1 year ago

  In the past 2 days, I learned about the rem, and the magic number for the rem is 16. It included more math. I edited all the code from index.html and started again with main.css. I spent some time to leant about GIT and GIT comands. Q: Does the best practise consist of keeping the code as clean as possible? Q: Shall I start another challenge or shall I keep working on this one till I feel confident with my work?

  I hope this time I'm better with this solution.

  Thank you

  

  QR-code-component [HTML & CSS]

  3

  3

  0

  

  Abdulelah• 540

  @Abdulelah-Abacar

  Posted over 1 year ago

  welcome leviathan, I hope you have a good time during this exercise .

  at first you need to take care abut containers it good for readability and when you make responsive design .

  and about your question: the first one yes it is. the second no you have to go ahead and keep working on new things to get some experience. and in the end let me give you a tip you can use rem with no math at all by reset it in the html tag by say font-size: 62.5% and this way will make 1rem = 10px and this is so easy to calculate. I hope these notes are give you some knowledge^_^

  Marked as helpful

  0
• 

  João Vitor• 500

  @jvssvj

  Submitted over 1 year ago

  Hello my name is João Vitor and i have completed another frontend mentor challenge.🔗

  How can i improve and reduce unnecessary code? Leave your comment. 🙂

  

  QR Code Component

  1

  3

  0

  

  Abdulelah• 540

  @Abdulelah-Abacar

  Posted over 1 year ago

  Hello, jvssvj I wish you got nice time while solving this challenge.

  I have a small note on the project you made a good copy of the card and that was great :-D but you have to focus on the little details the card has a little shadow and it was a great place to practice on it, and that is all. I hope it was I great note to you.

  Marked as helpful

  0
• 

  Christina Knapp• 40

  @christinareanna

  Submitted over 1 year ago

  I found it tricky to get the background to be the same color, so I applied it to my App and the body. The mobile width that was given confused me because I like to start with 300px, but it said 375px, so I made the width be able to fit a 300px wide phone. I'm not sure if I took the best practices when doing this, nor do I know if it's accessibility friendly.

  

  Responsive React.js QR Code Challenge

  #bootstrap#react

  2

  3

  0

  

  Abdulelah• 540

  @Abdulelah-Abacar

  Posted over 1 year ago

  Hi, Christina I hope that you had a great time while doing this challenge. I have some note on the code, At first it will be good if you take care about "block Element" width because by default they take the full width so when you set the width to be 100% it may cause problems later. And I hope that make sense for you ^_^

  Marked as helpful

  0