@jesuisbienbien
Latest solutions
Latest comments
- @AdrianX19
Hi @jesuisbienbien!
congrats on completing this challenge! really good job! :) The issue you have is caused because <small> elements is an inline and for such elements the top and bottom margin/padding has just not effect, you can do a couple of things to make it working for example you can replace <small> with some block element like <p>, you can change your current element to a block element by adding 'display: block' or you can add margin to your container 'email-error-container' :)
Marked as helpful - @jamespaulmiranda@AdrianX19
Hi @jamespaulmiranda!
Welcome on frontendmentor and congrats for submitting your first challenge! :) a few suggestions:
- to get rid off the accessibility/html issues there are two things you should do, first use semantic tags, so instead of having 'div' for your container use 'main', and instead of having 'div' for your footer, well.. you can use 'footer' tag! :). Second thing is the h3 you used, heading levels shouldn't be used for the styling purpose, it's just not a good practice and we have CSS for that purpose! so changing h3 to h1 and changing the fontsize through CSS would do the trick
- you might consider giving some min-width to your card so it doesn't get squeezed so much with smaller viewport width
- you seem to be lacking the mobile version, you can achieve it on many ways but using media queries it's a good call most of the times! (https://www.w3schools.com/css/css_rwd_mediaqueries.asp) :)
Have a good day! :)
Marked as helpful - @MisterSlimak@AdrianX19
Hi @MisterSlimak!
really good job! If you'd like to get rid off those accessibility issues just replace your container 'div' with 'main' tag :)
- @bigmac369@AdrianX19
Hi @bigmac369!
Congrats on submitting the challenge! A few minor things I've noticed:
- the accessibility issues you have can be solved by changing the #root 'div' to a 'main' tag
- background colour of the join community section is a bit off comparing to the design, it should be white
- monthly subscription text should be aligned to left, to achieve that you should probably set 'align-items' property to 'flex-start' for this section
- the 'monthly subscription' and 'why us' cards should be aligned, I believe you could achieve that by changing justify-content for those cards to 'space-between' and them add the same top and bottom padding for both of them
Keep it up! :)
Marked as helpful - @DonUggioni@AdrianX19
Hey @DonUggioni!
A hover effect for the button would be a nice cherry on top but other than that really nice submit!
- P@DarrickFauvel@AdrianX19
Hi @DarrickFauvel
really good job, well done! I would just try to make the sizes a bit closer to the design, right now the card seem to be pretty narrow, I would suggest increasing the max-width on .card element and I would increase padding for the .card-body, other than that it looks really good! :)
Marked as helpful
