Skip to content
OverviewSolutions
5
Comments
13
Yuliya
@Ambrolla

All comments

  • Yuliya•230
    @Ambrolla

    Hi!

    Good job! However, I notice couple of things.

    1. Your second line from the bottom is a little off from where it should be (more on the top, probably try to make font-size smaller). Second line where "0.041 ETH" and "3 days left". Both are a bit off.
    2. Don't forget about code refactoring :)

    But you did a very good job overall!

  • Yuliya•230
    @Ambrolla

    Hello!

    First, I wanted to say how much I love love how you did mobile toggle version! It's so interesting and different from what I've been stuck on lol However, second, in the desktop version, I suggest to add margin and padding to your navbar + login and register buttons are too far away from each other.

    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hello Adam!

    First, good job on your code and for trying! Second, I try to do my best following directions (answering your question about color gradient). So, yes, I think it is important. :) Third, there are some files in your github repo that I would include in the .gitignore. I recommend you reading about it! For example, you don't need to include style-guide :) And I'm a bit confused what is .css.map is, but I'll google it later.

    Fourth, I would suggest instead of this: <div id="1" class="number" onclick="ratCilcked(this.id)">1</div> <div id="2" class="number" onclick="ratCilcked(this.id)">2</div> <div id="3" class="number" onclick="ratCilcked(this.id)">3</div> <div id="4" class="number" onclick="ratCilcked(this.id)">4</div> <div id="5" class="number" onclick="ratCilcked(this.id)">5</div>

    Use event-target and event listener.

  • Yuliya•230
    @Ambrolla

    Hello!

    Answering your question about the behavior. Right when I press "submit", I only get 1 error. But when I click on the additional field, then I get an error in the fields where the info is missing. That's the only issue that you have :)

    1. Looking at code. I'm not familiar with gitlab, maybe they have something like gitignore, but I was curious why do you have assets folder?
    2. Don't forget to delete console.logs and your notes that aren't needed later from code :) Basically clean up and refactor code.
    3. Also, the hover/design is a bit different from the original :) For example, the button.
    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hello Franklin!

    Good job on functionality, but I agree with Dimitar about the design. Also, if you don't know about the .gitignore, I recommend researching about it.

    Also, style and code I suggest writing in the separate .css and .js file, if there are bigger projects, it's going to be confusing if you have everything in one file.

  • Yuliya•230
    @Ambrolla

    Hello!

    I've noticed couple of things, that probably needs to be fixed:

    1. Last name has specific amount of characters. However, some last names only have 2 letters.
    2. When I refresh the page, put in the html version in the input field "autocomplete: false" and it wouldn't let me see what I've already put when I refresh the page.

    But you have a good code! Keep it up! Good job!

    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hi!

    I've noticed some things, which will look better if you'll change them.

    1. In the quote, you forgot to add quotes.
    2. Also, I'd change the text color to plain white.

    But you did a good job! I wanted to go with your method at first too, but then I went with asynch, await function, which I've heard is better.

    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hi!

    I've noticed multiple issues.

    1. In the github, there are some irrelevant files like how design should look like, you don't have to upload it and you can skip it using gitignore.
    2. When I push rating, I can push multiple ratings and it is as if I've picked all numbers, not just one.
    3. In javascript, using variable var isn't as good.

    But overall, for the first js project, you did very good! Good job!

    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hi!

    Good job!

    Some improvements can be made here:

    1. You can add margin (around 200-300px) at the bottom. Also, I didn't see any attributions.
    2. In html, you can make autofill false so that when you refresh, it will delete what you wrote in the input.
    3. When some of the fields are not filled out, there are no red letters + flag on the bottom of the input (error messages), you only have code (alert).
    4. In github, I saw that you've included actual design folder (how it should look like), you could just gitignore it :)
    5. Was confused by index.info folder on github as well.
  • Yuliya•230
    @Ambrolla

    Hi!

    Good job!

    However, there are a few comments:

    1. I suggest making footer notes and div at least with 30px margin apart from each other because they are chunked close together.
    2. There was also a flag or some icon in the challenge, which you had to put into the input fields when there was an error. I suggest you to put it :)
    3. When you refresh a page, I suggest you to turn off autocomplete (it's done in html input field)
    4. It doesn't check in the email input if it's an email or just random words.
    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hello!

    As of right now, I have couple of issues (without looking at your code): When I click on the number, it doesn't show what number I've picked (clicked) unless I click "submit". It needs to be fixed, I think :) And I suggest making a circle background where there is a star, a bit darker, it'll make an eye flow better.

  • Yuliya•230
    @Ambrolla

    Hello!

    The only big issue in css file I found is this: In .card you have: margin: auto; margin-top: 40px; Maybe pick one? :)

    However, in order to keep everything more organized, I write comments (if it's more than 1 thing, for example for @media), I write that it's going to be media or Card images, etc. There are no comments in your code in CSS and I really recommend it because if you'll go back in 3-6 months and start looking at it, you might find yourself lost (especially if it's a bigger piece of code).

    You did a good job, considering that it's your second repository! Keep going! And I'm serious!

    Marked as helpful
  • Yuliya•230
    @Ambrolla

    Hello!

    You did a good job overall and with your project, however I wanted to point out to couple of things that you might have forgotten or left out:

    1. In the "submit" button, the color is off.
    2. you forgot to include "hover" state for rating + for the submit button.

    But I Liked your JavaScript code!

    Marked as helpful