Navendu
@AshxaryaAll comments
- @Alearson@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨:
For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly, you can search for why you might want to use em values instead of px for padding, margins etc in some cases as well.
Have a great day/night ^^
Marked as helpful - @bastiSaa96@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
- @AlexDralur@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap up all the main content of the page instead of the <div> tag. With this semantic element, you can improve the accessibility of your page.
I see you decided to remove the attribution, if in the future you want to add an attribution to your page make sure to use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Make sure to add alternative text in your images. To do this simply add (alt="") for ex. <img src="icon-music.svg" alt=""> You can either add info about the image in that section or leave it blank depending on what the image is.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You seem to already be using rem values for font-sizes i suggest you watch kevin powells videos on rem em and other units and try and use them for margins, paddings, etc as well instead of pixels.
for your query on centering The most common way to center such articles is to use
body { display : grid; place-items: center; }
- @AlbertLexter@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
I see that you decided to remove the attribution from the HTML, if in the future you do want to attribution make sure you use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
- @guyanhdinh@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
Marked as helpful - @ahmadfaa1z@Ashxarya
Hi! 😊
I have some feedback to help you out.
CSS 🎨: I see that you have made use of variables in your root, you could try adding colours as variables as well for better ease of access in future projects.
You seem to have used em for font sized in some places, as general rule of thumb font sizes tend to use rem whereas spacing uses rem and em, you can learn more about this here.
As for your question on mobile first, there are many sources on youtube and other websites. A basic idea is to build your website around the mobile version first and then add a media query of let's say min-width:600px to then make the desktop version. Here is a video on why it might be better to do mobile first.
Have a great day/night ^^
Marked as helpful - @michel-moreira@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: I think for smaller projects like this it's much better to only have one stylesheet rather than multiple to have better ease of access and less clutter.
Have a great day/night ^^
Marked as helpful - @zaphod207@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
I see you decided to remove the attribution, if in the future you decide to place it at the bottom make sure to use the <footer> tag to wrap the footer of the page instead of the <div class="attribution"> you are given in the original file. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Make sure to add alternative text in your images. To do this simply add (alt="") for ex. <img src="icon-music.svg" alt=""> You can either add info about the image in that section or leave it blank depending on what the image is.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
Marked as helpful - @enyindatemple@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
Github is case sensitive, perhaps the reason your image is not showing is because your image file is using capital I instead of small i, you can edit this directly in your github repo.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Make sure to add alternative text in your images. To do this simply add (alt="") for ex. <img src="icon-music.svg" alt=""> You can either add info about the image in that section or leave it blank depending on what the image is.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
- @skizzo112@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄: As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 instead of a h2 for the first text. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here, similarly, you can search for why you might want to use em values instead of rem for padding, margins, etc in some cases as well.
Have a great day/night ^^
Marked as helpful - @Vanglepu@Ashxarya
Hi! 😊
I think youve done an amazing job, heres some little things that could polish your code some more.
HTML 📄:
Everythings seems to be done to a T, you could move your attribution style to your css sheet from your HTML file for better accesibility for yourself.
CSS 🎨:
For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
Have a great day/night ^^
Marked as helpful - @farsana-fr@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 instead of a h6 for the texts. H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more as a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
As for centering : One of the easiest ways to do this is by giving your body (which you seem to have named as frame in your stylesheet) a min-height of 100vh. Then using grid to center everything inside the body. For ex. ``` body {
min-height: 100vh; display: grid; place-items: center; position: relative;
}```
For further understanding/alternative methods of centering, you can check out solutions from other people as their code can be accessed by everyone.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins, etc in some cases as well.
Have a great day/night ^^
Marked as helpful - @DayyaanAntunes@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-one heading for the first text. Think of them less as a way to size font and more as a way to show the hierarchy of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap up all the main content of the page instead of the <div> tag. With this semantic element, you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
Have a great day/night ^^
- @kumaarakg@Ashxarya
Hi! 😊
I have some feedback to help you out.
Make sure you look at the accessibility report you're provided with below your solution.
HTML 📄:
As you can see in your accessibility report, you are recommended to use a level-two heading as in h2 instead of a h5 for "Annual plan". H tags improve user experience in the sense that they're part of a web page's hierarchical structure. Think of them less as a way to size font and more of a way to show the order of headings, since the size can be manipulated in CSS regardless.
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
Make sure to add alternative text in your images. To do this simply add (alt="") for ex.
<img src="icon-music.svg" alt="">
You can either add info about the image in that section or leave it blank depending on what the image is.CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here , similarly you can search for why you might want to use em values instead of px for padding, margins etc in some cases aswell.
Have a great day/night ^^
- @tetinhxuan@Ashxarya
Hi! 😊
I have some feedback to help you out.
HTML 📄:
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
As you can see in your accessibility report, you are recommended to use a level-one heading as in h1 instead of header.H1 tags improve user experience in the sense that they're part of a web page's hierarchical structure.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here
You seem to have also used the mobile background image instead of the desktop background image which may be the reason why it seems off.
On the topic of mobile, the given style guide suggests using a mobile width of 375px, although you do not have to follow the guide to a T this will help make the website responsive for smaller devices.
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here
Have a great day/night ^^
Marked as helpful - @BigCrazyBrain@Ashxarya
Hi! 😊
I have some feedback to help you out.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this here
You may want to also use rem instead of pixels for font-sizes! You can learn more about this topic here
Have a great day/night ^^
Marked as helpful - @Gautam1201@Ashxarya
Hi! 👋. Good job on completing the challenge!
I have some feedback to help you out.
HTML 📄:
Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.
Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
You can also move the attribution style from the HTML into your stylesheet
CSS 🎨: For ease of access in future projects, you can create variables of different colors at the beginning of your sheet. You can read more here to learn about this.
Happy Coding!
Marked as helpful