All comments

• 

  Clytax• 120

  @Clytax

  Submitted almost 2 years ago

  Here are some questions I have:

  1. did I do responsive design correctly? I added media queries through Sass on individual elements instead of one big media query.

  2. should I have chosen a dynamic width/height for the elements of the rating number?

  3. any feedback is welcome!

  

  Responsive Rating Card

  #bem#next#react#sass/scss

  3

  4

  0

  

  Clytax• 120

  @Clytax

  Posted almost 2 years ago

  Wow, thanks for the amazing feedback! This is really useful and I will try to change some things immediately! I've heard about not setting heights a lot, but I've never been comfortable with it I think it's just something you have to get used to. And I need to get used to rem too, not so sure about that yet but a little research will do it :)

  Thanks again!

  0