All comments

• 

  Alex•50

  @alexvdc

  Submitted over 2 years ago

  

  news-homepage-main

  3

  40
  

  Daniel Brož•40

  @DanoBroz

  Posted over 2 years ago

  Hey Alex,

  I like it, you've made your code readable and kept the consistency through out the whole project.

  There's one pinpoint I found, since you're using grid and flexbox I'd suggest to use images as background of elements and set their background-position, repeat and so on, so they'll keep same ratio. For simple and quick use, you can add style shorthand like this: background: url('image-url') center / cover no-repeat;

  0
• 

  Trenton Bensheimer•190

  @tbensheimer

  Submitted almost 3 years ago

  

  GitHub User Search API project

  5

  111
  

  Daniel Brož•40

  @DanoBroz

  Posted almost 3 years ago

  Hi Trenton, I love that you've chosen a mobile-first approach and were able to set this up with VanillaJS. Firstly, as a friendly colleague FE developer, I'd suggest to be more aware of the colours, shadows and paddings provided in the design file, it gives a lot more value and refers how much you care about the project. Secondly, with APIs there's always a chance of some data not being provided, so I'd look into nullability with promises.

  0

  Marked as helpful
• 

  P

  Jordan Phillips•425

  @JordanPhillips-hub

  Submitted almost 3 years ago

  

  Github User Search App

  #react#typescript#tailwind-css

  1

  30
  

  Daniel Brož•40

  @DanoBroz

  Posted almost 3 years ago

  It's nice you've selected the mobile first approach, but It seems you forgot about desktop view. In the design provided you can find that the content of the app is 730px wide on the desktop (so just like in your breakpoints it would be 768px up). I'd suggest to add other breakpoint rules ex. between 481px — 768px - tablet and implement desktop view for higher breakpoint.

  0