All solutions

Hello Seniors, this is my first react project. I Have been so busy at work that It's hard to find time to learn, kindly help me to review this solution.

Here are my questions:

• Do I always have to set dummy values for states before data arrive from the API like I did here?

 const [advice, setAdvice] = useState(
    {
      "slip": {
        "id": 0, 
        "advice": ""
      }
    }
  )

• Is there any details I am missing in the UI?
• kindy go through my react code, what should I improve on?
• what do you think of my BEM class name usage? am I getting it?

Hello my Lovely Developers, This is my solution to the Intro section with dropdown navigation challenge using HTML 5 Semantic tags, CSS 3, SASS(SCSS syntax) and javaScript, Here are some of the Extra things I added

• My navigation links and image hover style on desktop:<br/> I use javaScript mouse-tracking to add a dark circle behind each nav links and the dark circle follows the, the same is done on the image using grayscale backdrop
• I used SVG for the text/logo "snap" and animates it.

Here are my questions:

• do you think I use the HTML 5 Semantic tags correctly?

• do you think it's a good idea to always use ID only to select element from the javaScrip without a special reason(I mean for DOM manipulation)?

• please do you know why the skip to main content isn't showing on firefox browser?

• Is it inaccessible in anyway or Is there any accessibility feature you think I should add?

• in what aspect of my code do you think I should Improve on?

• Is there anything I did that you have a better way of doing?

• what do you think of my code? is it clean? Kindy tell how I can Improve that?

• do you notice any details left out in the design and How do think I can fix it?

😊😁 Hello mentors, I have been busy but now I'm back I just finished this challenge and all Observation, correction, etc are welcome 😁😁😁. I can wait to receive your suggestions.

Thanks to my Mentors @vanzasetia and @grace-snow and other mentors for the review of my previous solutions, I can't wait to see your review on this one as well. I just think doing the correction and explaining it will help a lot of friends out there. Please feel free to point out my mistakes.

Hello Everyone, All feedback/review/correction/suggestions are welcome.

I've finished this project since few days back but I just keep looking for errors to correct and that make makes me loop through an infinite loop of correction. But I guess it can't be perfect.

here are my question:

• I used the markup below but I'm seeing some weird black border under/over my pink border, it kinda look like a default border, but I was expecting it to be overwritten by my style below, but it's not. kindly help to check what the problem is, this is my first time using :focus-visible.

a:focus-visible {
  border: dotted 0.3rem var(--Soft-Pink);
  padding: 0.3rem;
}

• I used positive and negative border to make the boxes slightly away from each other, is there a better way ?

• does the markup below work that much for SEO ? and what other <meta> would you recommend ?

<meta name="description" content="This is Engineer Hamziey's solution to FrontendMentor challenge(social proof section master)">
<meta name="Keywords" content="Web developer,Engineer Hamziey, Frontend developer">

• For the media query I used @media (min-width: 1024px) for the desktop, the design doesn't look satisfactory on screens lesser than 1024px in my opinion, any comment on that? what's your opinion?

I just finished this challenge, it took me roughly two days, even though I was busy in my workshop I'M OPEN TO ALL SUGGESTION @vanzasetia, @grace-snow thanks so much for the previous comments on our challenges...you guys are amazing, I'll be happy to see you review this challenge.

Hello Everyone, I just finished this project and all suggestions are welcome 😁 thanks

I did not understand the statement below(from the style-guild.md)

The designs were created to the following widths:

• Mobile: 375px
• Desktop: 1440px