JP Yepez• 55
@jpyepez
Submitted
Hi all,
Jumping back into front-end after a brief break. I gave this one a shot with only HTML, CSS and JS. I'd appreciate any feedback. Thanks!
Erik Tangvik
@Etang131
All comments
- Erik Tangvik• 255
@Etang131
Posted
To fix the background image on the thumb you might want to use: background-image: url("/images/icon-slider.svg"); background-repeat: no-repeat; background-position: center; background-size: auto;
Also how did you get your slider to change colors?
1 - Sangeetha Kumarasamy• 50
@sansk
Submitted
Feedback is always welcome.
Erik Tangvik• 255@Etang131
Posted
It looks like it matches the spec to me. I would consider making the media query change happen a bit later from mobile to desktop though.
0 - Isaac Galvan• 85
@isaacgalvan10
Submitted
Erik Tangvik• 255@Etang131
Posted
The biggest issue is that if you don't submit an email address your code doesn't allow for the user to change that. Other than that it's pretty close to the design.
0 - Jessica Ary• 65
@jessicaary
Submitted
Erik Tangvik• 255@Etang131
Posted
It's really close to the design. On the Why us section I would space those out a tad more. Also I think the font weight is a bit different.
0 - Cleberton Junior• 20
@clebsjr
Submitted
Erik Tangvik• 255@Etang131
Posted
Great job on your first project.
1 - Jenny• 40
@jenny07007
Submitted
Erik Tangvik• 255@Etang131
Posted
Your information bar looks better than the design. However I would make the search bar and search bar font a bit bigger.
0 - Kenard Ellis• 255
@Nard00
Submitted
Input would be appreciated.
Erik Tangvik• 255@Etang131
Posted
I think the only thing is the font weight that is off. Everything else looks like it's correct in desktop mode.
1 - Emmanuel Izuchukwu• 10
@NobleSalt
Submitted
Please can my project be criticized ?
Erik Tangvik• 255@Etang131
Posted
You need to make the width quite a bit smaller. Also add a <br> tag after the word reviews and set it as display none in mobile.
0
