Skip to content
OverviewSolutions
12
Comments
12

Lê Hoàng Long

@JamesWallison1Viet Nam, Son La290 points

Interested in Python (My first learning programming language)

I’m currently learning...

HTML, CSS, JavaScript, C++, Python

Latest solutions

View more solutions

Latest comments

  • P
    Omair Majid•100
    @BigO-Dev
    What are you most proud of, and what would you do differently next time?

    I'm most proud of how quickly I completed this project. Something I would do differently next time is to give better class names. I'm still new to the BEM methodology, so I have yet to have a good handle on coming up with good class names. I would also probably add a bit more interaction to the buttons.

    What challenges did you encounter, and how did you overcome them?

    There was nothing particularly challenging about this project.

    What specific areas of your project would you like help with?

    Any advice on best practices and responsive design is welcome.

    Social links profile using HTML and CSS

    #bem
    1
    Lê Hoàng Long•290
    @JamesWallison1

    Really really good! Your code is super clean and logical in readibility as well as accessibility! Really impressive. Just wanna ask, in your CSS, the media query is not filled up yet but just the comment about what to do in that part. Maybe this is just about forgetting. So if you can, please consider taking it into account, media queries are really important also. And you are good to go, again I have to admit your code is really clean, keep improving! Thanks a lot for reading this small comment!

    Marked as helpful
  • andiaz•150
    @andiaz
    What are you most proud of, and what would you do differently next time?

    I feel really happy that my speed with translating a design to HTML and CSS is picking up. I think I implemented this one from start to finish in less than hour, feels great.

    What challenges did you encounter, and how did you overcome them?

    While I can do static widths fairly well now, I wonder how it'll work when I do more responsive design. So I'm hoping to learn that better soon :)

    What specific areas of your project would you like help with?

    Any feedback in terms of HTML and CSS structure, semantics and best practices in general would be very appreciated!

    Social links profile

    2
    Lê Hoàng Long•290
    @JamesWallison1

    Really impressive! This solution is really really amazing I have to admit. Just wanna ask if you did miss the media queries or not? Media queries is really important, maybe your code right now is no need for media queries but further challenges will require media queries, such like "create three dots in phone query,..." So if you didn't remember to add it, make sure to take it into account! And you're good to go! Thanks a lot for reading this small comment

    Also you are the second person to have this container "perfect pixel". Everything is alike about 98% of the design. So keep pushing and pushing to be more successful. Again, congratulation!

    Marked as helpful
  • Lê Hoàng Long•290
    @JamesWallison1

    Really really amazing! This is one of the cleanest and most stylish 3 column card I have ever seen. Really impressive! There is litterally no mistake to talk about. Just wanna remind you if you want to be as closest as possible to the first design, you can change the height of the container. Also the button, you can change to the color white or hide the border, but you know, this is up to you, no need to follow to the design. And the rest is litterally perfect. Good job!

    Marked as helpful
  • osenprema•170
    @osenprema
    What are you most proud of, and what would you do differently next time?

    I am proud of the use of CSS to define the size of the texts and the general design elements.

    Social Links Profile using HTML and CSS

    1
    Lê Hoàng Long•290
    @JamesWallison1

    You're doing great! Congratulation of completing one of the FEM challenges, really impressive I have to admit! It is great from the first look but there are some mistakes we need to discuss about.

    • First, it is considered that you use landmarks instead of div. Landmarks are such like: <main></main> <section></section> <footer></footer>,... using div is not wrong but it can not describe what is the role of each individual part? So consider changing those div to main based on what the role of that part is.
    • Second, I am seeing that your card is not being centered properly, well there is a tip for you is that using: margin: 0 auto This will automaitcally center your whatever div, so consider adding that to your css

    And you are good to go! Your solution is really great I have to admit! So keep practicing and practicing for perfection! Thanks a lot for spending time reading my small comment

    Marked as helpful
  • Darren Ogola•60
    @Ogo1A
    What are you most proud of, and what would you do differently next time?

    i am able to understand has time goes by i am so greatfull

    What challenges did you encounter, and how did you overcome them?

    i encountered some margin and border area difficulty

    What specific areas of your project would you like help with?

    margins padding spacing and implimating fonts

    CSS Margin and Html

    1
    Lê Hoàng Long•290
    @JamesWallison1

    Congratulation on completing one of the FEM challenges! You are doing great but there are multiple mistakes that need to be fixed, I also really want you to take it account too!

    • For the first one: we will discuss about landmarks, this is important, the code you are using here is declaring a class with a div, but the div can't tell what is the role of that part so landmarks help this, using <main></main> <section></section> <footer></footer> is like a command, it helps better accessibility and also better styling of code. For example, with the paragraph part, instead of writing:
            <h3>
          These language are the backborn of every <br />website,defining
          structure,content and <br />presentation
        </h3>

    You can change to:

            <h3>
          These language are the backborn of every <br />website,defining
          structure,content and <br />presentation
        </article>

    So remember adding that into your next solution!

    • For the second thing, you are totally different from almost everyone in FEM because of using clip-path, well knowing that you are trying to create the border-radius for the elements in that container but this can cause to time-consuming and difficulties when reading code. So instead of using clip-path, you can use border-radius instead!
    • Thirdly is about centering your card, your card here is not properly centering and there is a pro tips that can center it easily without any difficulties, using margin: 0 auto; in CSS at your container will automatically center in the middle of the screen. About the height, you can add min-height: 100vh; display: flex and align-tems: center this will also automatically center the card in the height.
    • And there are also some minor mistakes like padding and margin: well this is depends on your way of thinking, if you want it to be more beautiful add the font and adjust the padding and margin. And you are good to go! You are doing great! So keep pushing yourself to become a successful front-end develop! Thanks a lot for spending time readin this small comment!
  • Sumedha Koranga•70
    @sumedhakoranga
    What are you most proud of, and what would you do differently next time?

    I am working on the projects. I will learn more.

    What challenges did you encounter, and how did you overcome them?

    Nothing now.

    What specific areas of your project would you like help with?

    Provide your feedback, like how should I write in a standard way. what tools should i use, which will help me to learn more.

    Social Link Profile

    1
    Lê Hoàng Long•290
    @JamesWallison1

    This literally perfect! Congratulation on completing one of the FEM challenge, just wanna give some advice.

    • This is a small tip when displaying code is that you should consider using landmarks instead of div, using landmarks can help you describe better what each individual part of your code is so you can consider change div into <main></main>, <section></section>, <article></article> or <footer></footer>.

    And you are ready to go! Trying hard more to become a successful developer! ;) Thanks a lot for reading this small comment

View more comments