@Julia-Fidison
@csphilli
Submitted
I'm still trying to learn where to apply the specific Aria roles. Also, regarding the h3, since this is just a random QR on some empty page, the h3 is a guess.
Do <p> elements get an Aria role or should I have included that single element inside an <article> element?
@Julia-Fidison
Posted
Hello, Good job. I would like to give you a few suggestion if you don't mind.
In your html code. It will be easier for you and the other if you follow the html semantics for example <main class="container"> <img> <article> <h1>.......</h1> <p>.......</p> </article> </main> Concerning the heading I think you should always start with <h1> <h2> <h3> .... You can't go to h2 after h1, they need to follow a chronological order if you want to change the font-size of your heading just override it in you css Learn more about that here And more about the html semantics
@sadykova
Submitted
Hi fellow coders,
This is my solution to the QR component challenge:) Looking forward to your feedback!
@Julia-Fidison
Posted
Hello, Great job. I would suggest you to import your google font like @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@100&display=swap'); in your stylesheet as you already have a separate style.css.
And change the color to h1 by Grayish blue: hsl(220, 15%, 55%).
I think you should make you're site responsive by using media query as: 320px — 480px: Mobile devices 481px — 768px: iPads, Tablets 769px — 1024px: Small screens, laptops 1025px — 1200px: Desktops, large screens
You can learn more about that here
Marked as helpful
@boostbm
Submitted
This took me a couple days and I know it's not picture perfect but I just decided to upload the solution. Any feed back helps!! Thanks!
@Julia-Fidison
Posted
Hello, that's really a great job. you have done here. I would like to suggest if you don't mind to use the html semantics like header, main, section... instead of div. So it will be easer for you and the other to read your code. Example:
<main> <header> <h1>title</h1> <p>paragraph</p> </header> <main>Marked as helpful
@Julia-Fidison
Submitted
Hello, any feedback will be welcome. Especially, on the media query part to make the site more responsive.
@Julia-Fidison
Posted
Thanks a lot for your feedback. I really appreciate.
