Henrique• 100
@UnaspHenrique
Submitted
Any feedback is welcome!
Desktop @media (min-width: 1088px).
mobile @media(min-width: 375px) and (max-width: 414px).
Hope u like it!
let's go brazil!!!
Kakamotobi
@Kakamotobi
All comments
- Kakamotobi• 160
@Kakamotobi
Posted
Hi Henrique.
Your styles break between 414px and 1088px. I think you should remove the max-width of 414px. Looking at your css file, it seems you started off with media query settings. I suggest styling your page first and then add media query settings.
Otherwise, well done!
0 - drallas• 375
@Drallas
Submitted
I managed to complete the 'Four card feature section' and this one was fun too. I wanted to use the Grid system since the four cards seemed perfect for that. Never used the Grid System before outside tutorials, so i had to read the Complete Guide on CSS Trick again.
I think I did a good job on this more details about my choice and coding experience are in the README.md.
Feedback would be welcome : How is my CSS, what can I do better / more efficient? Did I use the Grid system correctly?
Thanks for any help.
Kakamotobi• 160@Kakamotobi
Posted
Hi Drallas. I think you could also use more semantic html. For example, you have a <div> with a class of header. Instead, you could use the <header> element. And maybe for the element wrapping the cards (the main content of your page), you could use the <main> element.
0
