All comments

• 

  Dominik-Gryszkiewicz• 210

  @Dominik-Gryszkiewicz

  Submitted about 2 years ago

  I will be grateful for any feedback or suggestions.

  

  Tip calculator app

  #bem#sass/scss#webpack

  2

  6

  0

  

  Luka• 180

  @Luka85

  Posted about 2 years ago

  Hi! The solution looks good, but I want point out few things that i notice:

  • when you insert a bill amount and then you click a tip button, number of people input notification can't be zero automatically pop up from the start even that I haven't insert anything there, maybe you could just move focus on number of people input nad remove that notification from the start and then it can pop up later if it's empty.
  • the second thing is when you actually put some value into number of people input you don't get results I mean you get result when you click the other percentage button but you don't get the result from the start when you click the first button.
  • try to do different scenarious, like try hoping around and clicking different percentage buttons, or insert custom percentage or change the number of people value or changing the bill amount, everytime the result needs to be updated.

  Hopefully this was helpfull, clear and understandable.

  Cheers

  Luka

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Luka• 180

  @Luka85

  Submitted about 3 years ago

  

  HTML and CSS ( Flexbox) 3 column preview card component

  2

  1

  0

  

  Luka• 180

  @Luka85

  Posted about 3 years ago

  Hi Grace.

  Thank you so much for your feedback, it helped me a lot, cause I am still "new" in this field. I was more concerned about my CSS then HTML, but everyday you learn something new.

  Thanks again and have a great one.

  0