Skip to content
OverviewSolutions
13
Comments
136
MikevPeeren
@MikevPeeren

All comments

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Try not to add alt text to meaningless icons like the Facebook icon, a screenreader has no use for that.

    Also try to diversify your html elements, for example using headers and using lists for the different data.

    Other than that good job 👏

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job 👏

    Try to keep in mind when using alts text if it adds any value to a screenreader for example the background images do not. In that case you can use alt="" as that would be better.

    Also as a improvement you could've used a ul list instead of divs for the footer section.

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Looks good to me, the only thing I can think about is that you could perhaps have predefined arrays with key value pairs this way you can just select your element for example for the housselection like:

    Sethouse = Array[num]

    And perhaps it would be cleaner to have two states one for the name and image.

    Also useStates should always be ordered at the top so the function in between is a no go.

    I would also have maybe a custom hook for your localstoragd to handle that.

    But for the rest good job

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job finishing this one 👏

    My only comment would be to not skip headings as you are now going from h1 to h3 you should try to use h2 in that case.

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Try to make use of headers instead of using paragraphs for everything. Also try to add alt text to images that require it, if they don't require it use alt="".

    For your question I personally used buttons for the interactions but a list would also be fine imo.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    My only comment would be to add more descriptive alt txt for accessibility a d also to remove it for non saying images like the eye icon, for those your can use alt=""

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    For the overlay the color is now blueish you can use something like the following:

    ​background-color​: ​hsl​(​277​, ​64​%​, ​61​%​);​ ​ background-blend-mode​: ​multiply​;

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Try to keep in mind when to add alt text to images and if it's of use for a sxreenreader. For example for these images it isn't. Also always start with h1 and go from there.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job finishing this one 👏

    The on hover for the nft image is wider than the image as the div surrounding it triggers it resulting in that div also having the bg color.

    Furthermore I am missing alt text for the nft as that is important data to have for a screenreader.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    I am missing a bit of margin at the bottom so that it isn't clamped to the bottom of the div. Also the view code is linked to your profile so it's hard to find the repo.

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job finishing this one 👏

    Try to add the font as is the same as the design it usually is written in the style guide. You can then import it as its described on Google fonts. https://fonts.google.com/

    I am also missing the overlay over the image you can do it as follows:

    ​  ​background-color​: ​hsl​(​277​, ​64​%​, ​61​%​); ​  ​background-blend-mode​: ​multiply​;

    This needs to happen in css tho where you load the image in css.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job looks good on mobile.

    However try to start with header 1 and increment it rather than starting with a header 2. Also try to double check your code as you copied your alt text to multiple images.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job finishing this one 👏

    My only comment would be to add more descriptive text for the nft as a screenreader would like to know what they are buying.

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Make sure to add alt text to images if the image does not add anything anything screenreaders just add alt="".

    For the rest good job 👏

  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    On mobile the share modal is already open. Also I can't open your github url did you add it correctly ?

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job, my only comment would be to add a transition to the share modal so it appears nicely in view.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    Good job 👏 I like the hover effect on your image.

    I am seeing a double quote in your html however before a alt text. Als the alt texts are not needed for the icons and for the nft I would add a more descriptive text.

    Marked as helpful
  • MikevPeeren•2,100
    @MikevPeeren

    Hey 👋

    I can't really find anything other than maybe the image overlay being of a different color. Other than that great job 👏

    Marked as helpful