Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Log in with GitHub
OverviewSolutions13Comments136

All comments

  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Try not to add alt text to meaningless icons like the Facebook icon, a screenreader has no use for that.

    Also try to diversify your html elements, for example using headers and using lists for the different data.

    Other than that good job 👏

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job 👏

    Try to keep in mind when using alts text if it adds any value to a screenreader for example the background images do not. In that case you can use alt="" as that would be better.

    Also as a improvement you could've used a ul list instead of divs for the footer section.

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Looks good to me, the only thing I can think about is that you could perhaps have predefined arrays with key value pairs this way you can just select your element for example for the housselection like:

    Sethouse = Array[num]

    And perhaps it would be cleaner to have two states one for the name and image.

    Also useStates should always be ordered at the top so the function in between is a no go.

    I would also have maybe a custom hook for your localstoragd to handle that.

    But for the rest good job

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job finishing this one 👏

    My only comment would be to not skip headings as you are now going from h1 to h3 you should try to use h2 in that case.

    0
  • xs30snw• 110

    @xs30snw

    Submitted

    I didn't know how to make a semantically proper switch between 'daily', 'weekly' and 'monthly' data.

    On one hand, it should be a navigation block, in which links are organized inside a list. But the challenge also has the feel of an app, where these buttons should rather be radio buttons.

    How would you implement this?

    Time Tracking Dashboard w/ Tailwind, Webpack, PostCSS and json-server

    #tailwind-css#webpack#sass/scss

    1

    MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Try to make use of headers instead of using paragraphs for everything. Also try to add alt text to images that require it, if they don't require it use alt="".

    For your question I personally used buttons for the interactions but a list would also be fine imo.

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    My only comment would be to add more descriptive alt txt for accessibility a d also to remove it for non saying images like the eye icon, for those your can use alt=""

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    For the overlay the color is now blueish you can use something like the following:

    ​background-color​: ​hsl​(​277​, ​64​%​, ​61​%​);​ ​ background-blend-mode​: ​multiply​;

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Try to keep in mind when to add alt text to images and if it's of use for a sxreenreader. For example for these images it isn't. Also always start with h1 and go from there.

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job finishing this one 👏

    The on hover for the nft image is wider than the image as the div surrounding it triggers it resulting in that div also having the bg color.

    Furthermore I am missing alt text for the nft as that is important data to have for a screenreader.

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    I am missing a bit of margin at the bottom so that it isn't clamped to the bottom of the div. Also the view code is linked to your profile so it's hard to find the repo.

    0
  • Tarık• 330

    @developertarik

    Submitted

    I know that I have many shortcomings but I really tried hard to make the site look like I am waiting for your help I need help I am new to the front end field I am waiting for your opinions thank you in advance

    Stats-preview-card-component

    2

    MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job finishing this one 👏

    Try to add the font as is the same as the design it usually is written in the style guide. You can then import it as its described on Google fonts. https://fonts.google.com/

    I am also missing the overlay over the image you can do it as follows:

    ​  ​background-color​: ​hsl​(​277​, ​64​%​, ​61​%​); ​  ​background-blend-mode​: ​multiply​;

    This needs to happen in css tho where you load the image in css.

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job looks good on mobile.

    However try to start with header 1 and increment it rather than starting with a header 2. Also try to double check your code as you copied your alt text to multiple images.

    Marked as helpful

    1
  • Anthony Rosman• 510

    @D3press3dd

    Submitted

    This is my first challenge, the most difficult part for me was the hover in the image, i think i could improve a little bit more, but im still learning, im so proud that i could did it, happy codding guys♥,

    Nft Card Component Solution

    5

    MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job finishing this one 👏

    My only comment would be to add more descriptive text for the nft as a screenreader would like to know what they are buying.

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Make sure to add alt text to images if the image does not add anything anything screenreaders just add alt="".

    For the rest good job 👏

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    On mobile the share modal is already open. Also I can't open your github url did you add it correctly ?

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job, my only comment would be to add a transition to the share modal so it appears nicely in view.

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job 👏 I like the hover effect on your image.

    I am seeing a double quote in your html however before a alt text. Als the alt texts are not needed for the icons and for the nft I would add a more descriptive text.

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    I can't really find anything other than maybe the image overlay being of a different color. Other than that great job 👏

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    I am missing the background image 😢

    Also try to start with h1 and increment by 1 throughout your html, also do not add empty src sets for images as it does nothing.

    Other than that great job 👏

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Try to start headers with h1 rather than h2 and then increment by 1. Also leave alt text for images empty when they add nothing to screen readers also on mobile the component reaches the edge of the screen a margin or padding would solve this problem.

    I am also missing the background image 😢

    But for the rest good job 👏

    Marked as helpful

    1
  • KXLA• 120

    @KXLAA

    Submitted

    Let me know what I can improve, especially in regards to how I organised my folders. The CTA on the homepage lacks the background pattern due to some bug I'm still trying to fix, but the CTA on other pages are good.

    Thanks in advance xx

    Designo multi-page website built with Next.js

    #next#styled-components#react

    1

    MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    For pages when you have multiple pages you can move them into their own folders except for the document app and 404. For example app-design.js would be app-design/index.ts. also remove boilerplate like the api folder and home.module.css.

    I would also use component level css rather than styled components https://nextjs.org/docs/basic-features/built-in-css-support but I am not a big fan of styled components in general.

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    I am getting a 404 I am afraid 😨

    Marked as helpful

    0
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job finishing this one 👏

    My only comments would be to use headers as that would be useful for seo. And to not use empty src sets for images.

    Marked as helpful

    1
  • MikevPeeren• 2,100

    @MikevPeeren

    Posted

    Hey 👋

    Good job 👏

    Try to add more descriptive alt text when you do, for example profile picture of ... would be better than avatar. Also try to use headers rather than just p as that would improve seo when and if a website goes live.

    Marked as helpful

    1