Skip to content
OverviewSolutions
25
Comments
11
Martha
@Mtc-21

All comments

  • Martha•510
    @Mtc-21

    hi congratulations, your all jobs are great! how did you learn all this? some tutorial, book or website you recommendend, i didn't know the intersection observer API, it looks great. I have knowledge in css, html and js, but if I don't arrived here, it would take me months to know that it exists this API

  • Martha•510
    @Mtc-21

    Hi merry christmas, thanks for your comments and the suggestion 👍, i have applied some of your suggestions, I haven't applied the fieldset tag change yet, but I understand you say the relation with sr-only.

  • Martha•510
    @Mtc-21

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, leading zeros, the following 0123 is taken as a positive number.
    • do not allow data like this 12-2
    • no decimals should be allowed in the person field in addition to the above.
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, it does not make sense.
    • If you hover over the field and delete the information, the totals should be reset according to what is entered in the field.
    • see the accessibility issues thrown at the time of loading the challenge, they are helpful.
    Marked as helpful
  • Martha•510
    @Mtc-21

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, zeros to the left, the following 0123 is taken as a positive number
    • do not allow data like this 12-2
    • in the person field no decimals should be allowed in addition to the above
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, does not make sense.
    • If you position over the field and delete the information, the totals should be reset according to what was entered in the field.
    Marked as helpful
  • Martha•510
    @Mtc-21

    greetings some recommendations:

    • make an effective validation of the fields, that indicates to the user a message with the errors.
    • do not allow data in negative, zeros to the left, the following 0123 is taken as a positive number
    • do not allow data like this 12-2
    • in the person field no decimals should be allowed in addition to the above
    • in the person field a number >100 should not be allowed in addition to the above
    • the number of persons should not be greater than the invoice number, invoice to 1 and persons to 50, does not make sense.
    Marked as helpful
  • Martha•510
    @Mtc-21

    greetings I recommend you to see the accessibility problems thrown at the time of loading the challenge, are of great contribution for future projects, additionally

    • make an effective validation of the fields, which indicates to the user a message with the errors
    • do not allow data in negative, leading zeros, the following 0123 is taken as a positive number
    • data like this 12-2 should not be allowed
    • in the people field it should not allow decimals in addition to the above -in the custom field it should not allow in addition to the above a number >100; -the color of the reset field is as gray starting with
  • Martha•510
    @Mtc-21

    1)Hi excellent work, in the mobile version the email validation does not work, the logos belong in the footer and copyright.

    2)Suggestion, see the accessibility reports and use some css and html validator before uploading the content, it will help you a lot.

  • Martha•510
    @Mtc-21

    I have found the answer to my question, I hope it will help someone here is the link to the answer and a possible solution

  • Martha•510
    @Mtc-21

    other than disabling the autocomplete attribute of the input, thank you.

  • Martha•510
    @Mtc-21

    Hello, your design is fine, I would only add the background images with a background-image:url() to the body, with background-position: place one to the left and the other to the right, with the following link you can support Link, with the positioning, I recommend you to work with vw so that they remain in the same place.

    • for your card to be centered you must set the html tag and the body in min-height:100vh, if you set only the body in height:100%, it will not work, as far as possible avoid using % or absolute units such as px, it is recommended to use rem or in some examples of use

    • there should be only one h1 tag in the document, normally inside the main, outside tags like div, section, article, etc, tags like section and article should have some descriptive title tag, between h2 and h6, I recommend you to read some html semantics, here some support links Link 1 Link 2

    • additionally it would be ideal that you see in the section of report the problems of accessibility or html that presents the site that you created, always they provide you a link of reference to correct the error.

    Excellent work 👍

    Marked as helpful
  • Martha•510
    @Mtc-21

    hello your design looks very good, the border thing you mentioned happened to me, it's more noticeable when you work with rem, that's why I used px and as the px value increased, the empty space was no longer visible, try it.

    Marked as helpful