@markestrada8
Submitted
I have trouble getting the proportions of elements to carry across different media, this is the main reason I am here, to learn responsive and proportional design.
Looking to hire developers?
@Nassim555
@markestrada8
Submitted
I have trouble getting the proportions of elements to carry across different media, this is the main reason I am here, to learn responsive and proportional design.
@Nassim555
Posted
Hi Mark!
Congratulations on your solution , I suggest to wrap your content in a main element
and I think you forgot to add alt text
to your images and I also suggest to to use h1
instead of h3
for the cards title as it's the first and only heading on your page all of these changes are necessary for improving accessibility there's a section on your frontend-mentor's solution page to check accessibility and Html issues .
Happy coding.
Marked as helpful
@correlucas
Submitted
👾 Hello, Frontend Mentor coding community. This is my solution for the QR Code Component.
Making this challenge again was something really amazing for me, first because going back through my past challenges I was able to fix some issues and clean my code and then because was my first time using JS (yes I'm a newbie) 😂
I added some features:
I'll be happy to hear any feedback and advice!
@Nassim555
Posted
Hi , great solution
I love your approach especially when u decided to add the dark and light mode to spice it up , one thing though it's preferred to cursor:pointer;
to show that the toggle is a clickable element.
Marked as helpful