Skip to content
OverviewSolutions
11
Comments
8

Nnadi Victory

@Nnadivictory25NIGERIA370 points

I am a frontend developer with keen eye for super responsive and neat websites. I have 2 years experience as a web developer. I am proficient in HTML, CSS3, SCSS/SASS, Tailwind CSS, Bootstrap, Git & GitHub, Gulp and JavaScript (ES6+).

I’m currently learning...

JavaScript

Latest solutions

View more solutions

Latest comments

  • Nnadi Victory•370
    @Nnadivictory25

    Just checked your solution, it's awesome man . But I made some observations that I think might be helpful for you

    • Your inputs shouldn't have a cursor:pointer on them
    • Your border offset when the input is focused on is much, you should just change the color of the existing border
    • Your name validation is not validating enough as I could put numbers in it and go to next step
  • Nnadi Victory•370
    @Nnadivictory25

    Just checked out your solution , here are some things I observed that might be helpful

    • You are not validating the inputs on step 1, users can proceed to step2 without filling the form . It shouldn't be so
    • On step2 too , you are not validating any selected plan , user shouldn't proceed to 3 without selecting a plan
    • Your placeholders too aren't what was in the challenge
  • Nnadi Victory•370
    @Nnadivictory25

    Just checked your solution, here are my observations I think might be helpful

    • The input should not have a cursor:pointer on them
    • Your error messages should be individualized
    • Your error message should also disappear after sometime
    • You are not validating the inputs well enough , don't just check if they're empty. Also check if the user put the correct email format, didn't put a number as name and also the email shouldn't start with a dot too
    • The steps container on the left should be fixed , it is always trying to adapt to the layout therefore resizing itself often
    • Your 'subs' should have a better padding-y i.e: top and bottom , the height should be higher
    • User shouldn't be able to proceed to step3 if they didn't select a plan too
    Marked as helpful
  • Nnadi Victory•370
    @Nnadivictory25

    Just checked out your solution man nothing much to add just a little observation

    • The 'carousel_desktop_image' should have a pointer cursor on it
    • The 'button_interact' should have a default value of 0
    • The add to cart button should be disabled also unless the value of 'button_interact' is more than zero
  • Nnadi Victory•370
    @Nnadivictory25

    Heyy man , just checked out your solution , here are things I think will be helpful

    • Your nav is longer in height, reduce the height
    • Your filter doesn't work also, it is not filtering the listings when I select a filter
    • The cursor should not be pointed on everything on the page
    Marked as helpful
  • Nnadi Victory•370
    @Nnadivictory25

    Heyy man , just checked out your solution Here are some things I think might be helpful

    • Your font weight on the navbar and the product info paragraph is too bold
    • Also the cart doesn't have any background color , rather I think u should set a lower opacity then on hover it'll be back to 1
    • In the cart , the img is not displaying or maybe you didn't include the img there? even the total is not being calculated
    • The thumbnails should overflow relative to the main top image and the active image should be indicated on the thumbnail images too
    • The old price is under the price not on the same line with it on desktop
View more comments