@OneManBanned
Nnadi Victory
@Nnadivictory25All comments
- @Nnadivictory25
Just checked your solution, it's awesome man . But I made some observations that I think might be helpful for you
- Your inputs shouldn't have a cursor:pointer on them
- Your border offset when the input is focused on is much, you should just change the color of the existing border
- Your name validation is not validating enough as I could put numbers in it and go to next step
- @AlexAgustini@Nnadivictory25
Just checked out your solution , here are some things I observed that might be helpful
- You are not validating the inputs on step 1, users can proceed to step2 without filling the form . It shouldn't be so
- On step2 too , you are not validating any selected plan , user shouldn't proceed to 3 without selecting a plan
- Your placeholders too aren't what was in the challenge
- @IcyEazy@Nnadivictory25
Just checked your solution, here are my observations I think might be helpful
- The input should not have a cursor:pointer on them
- Your error messages should be individualized
- Your error message should also disappear after sometime
- You are not validating the inputs well enough , don't just check if they're empty. Also check if the user put the correct email format, didn't put a number as name and also the email shouldn't start with a dot too
- The steps container on the left should be fixed , it is always trying to adapt to the layout therefore resizing itself often
- Your 'subs' should have a better padding-y i.e: top and bottom , the height should be higher
- User shouldn't be able to proceed to step3 if they didn't select a plan too
Marked as helpful - @YerikAH@Nnadivictory25
Just checked out your solution man nothing much to add just a little observation
- The 'carousel_desktop_image' should have a pointer cursor on it
- The 'button_interact' should have a default value of 0
- The add to cart button should be disabled also unless the value of 'button_interact' is more than zero
- @usmanahmedkhan09@Nnadivictory25
Heyy man , just checked out your solution , here are things I think will be helpful
- Your nav is longer in height, reduce the height
- Your filter doesn't work also, it is not filtering the listings when I select a filter
- The cursor should not be pointed on everything on the page
Marked as helpful - @kabocha23@Nnadivictory25
Heyy man , just checked out your solution Here are some things I think might be helpful
- Your font weight on the navbar and the product info paragraph is too bold
- Also the cart doesn't have any background color , rather I think u should set a lower opacity then on hover it'll be back to 1
- In the cart , the img is not displaying or maybe you didn't include the img there? even the total is not being calculated
- The thumbnails should overflow relative to the main top image and the active image should be indicated on the thumbnail images too
- The old price is under the price not on the same line with it on desktop
- @iDamjan@Nnadivictory25
Hey man , just went through your project and there are some things I will like to point that might be helpful
- First, the background color you used for the card should be the one for the body and vice versa
- Your borders links on details page should have same padding so they can take same size instead of clustering . The container of the buttons should also have a flex display with wrap to avoid overflowing which really spoilt your layout.
- P@MladenAntic@Nnadivictory25
Hey man There are some things I would like to point out so you can correct
- Your font sizes aren't consistent in the steps
- Your input fields shouldn't have a pointing cursor on them
- The 'go back' button shouldn't be seen on step1
- There is no need adding hover effects on the step numbers since clicking it doesn't really do anything
- When the form is validated and there is a wrong input, the error message should disappear after some time
- Update your validation so users can't put numbers as names or use only 1 number in the phone number input (as I was corrected by someone)
Marked as helpful
