All comments

• 

  M A• 170

  @Mikkobelly

  Submitted over 1 year ago

  I created a webpage using sass/scss for the first time. Please feel free to comment if you find anything can be written in better way. Also any idea for better navigation toggle functionality? I would appreciate any help!

  

  news-homepage-main

  #sass/scss

  1

  3

  0

  

  Odiesta• 100

  @Odiesta

  Posted over 1 year ago

  Hey Mikkobelly, Great progress after complete this challenge.

  I want to add suggestion on the layout. For better responsiveness try using CSS Grid on layout structure. For example:

  /* 10rem for navigation rows, 40rem for header and news, and 10rem for recommendation */
   grid-template-rows: [nav-start] 10rem [nav-end header-start news-start] 40rem [header-end news-end recom-start] 10rem [recom-end];
  /* 6 column divide evenly */
   grid-template-columns: repeat(6, [col-start] 1fr [col-end]);
  

  For the navigation section try using width: 0 and then width: 50% when opening menu in mobile screen. Set the position to absolute, top and right 0. then it will show from right.

  Also in navigation try creating a hidden class that contain display: none and use javascript to add and remove that class

  Marked as helpful

  0