All comments

• 

  NadiaFr•310

  @NadiaFrShLm

  Submitted about 3 years ago

  

  Accordion Card using SASS and JS

  #sass/scss

  1

  40
  

  Jinju Dixon•120

  @PerleMedia

  Posted about 3 years ago

  Hi Nadiafr,

  The project looks great, especially for your first time using SASS. Keep it up, you're doing awesome!

  The first column in your .card div (.img-box) is responsive--if you made that column a fixed width (maybe 400px on desktop?) it could be much easier to place the box svg and make sure it stays in the correct place, as the background image would then remain a single size. Rather than a responsive column, a fixed-width column that changes width based on device breakpoints might save you some headache in positioning!

  As for the SASS architecture, personally I only create as many SASS files as I need to use: for a site like this that may be 1-2, as you said. It's really up to you whether you want to include it in a .gitignore--personally I leave them in, along with a source map so that I can easily inspect the code on a live site and have it correspond to the SASS files instead of the compiled CSS.

  Also, adding a little bit of JS or CSS to animate the accordion as it opens and closes would be a lovely finishing touch!

  0

  Marked as helpful
• 

  Abu Bakr•30

  @AbuBakrBenMhenni

  Submitted about 3 years ago

  

  Todo App using HTML, CSS and JS

  1

  50
  

  Jinju Dixon•120

  @PerleMedia

  Posted about 3 years ago

  This is incredibly impressive for your first project with HTML, CSS, and JS--very well done! Really loving the subtle animations and responsive transition effects.

  Here's a great resource for drag and drop elements if you plan on building it out some more! https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API

  0

  Marked as helpful