@dianesancheril
Sarath Sundaresan
@Phoenix-dareAll comments
- @Phoenix-dare
Hi there, good work on completing the challenge!!
- It is definitely easier to center a div with flexbox or grid
Grid
.container { display: grid; height: 100vh; /* Set the height of the container to the height of the viewport or any other measures*/ place-items: center; /* Center the contents vertically and horizontally */ }
flexbox
.container { display: flex; align-items:center; justify-content:center; }
- But remember this does not apply to all use-cases. The positioning of the divs will vary from one use case to other. -You can go through this article centering-css
- More about positioning
**About the media-queries **
- There is no one-size-fits-all standard list of device media queries, as there are many different devices with different screen sizes and resolutions.
- This might be helpful media-query-github
*And finally practice. Good Luck! *
- @DevMathe@Phoenix-dare
I think the design is not responsive, I didn't see any responsive styling Read Responsive Design
Also you have to work on accessibility and semantic html Accessibility Semantics