Skip to content
OverviewSolutions
35
Comments
16
Vincenzo Marcovecchio
@VincenzoMarcovecchio

All comments

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Thank you so much for your answer

    Yeah I should fix the errors and be more concern to the designs

    One question, is it asking for your position the iframe ? I totally forgot to remove it

    FEM doesn't allow urls other than the ones they have whitelisted, this can be some kind of bypass? not really, but I just wanted to throw my solution in there. And also because I had d3 installed there

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey there, I like your navbar solution using CSS only, I think it can be used in production or at least it's very close but there are many bugs I noticed throughout the website that make it to be reviewed. Mostly you need to review heights and paddings your are giving to sections (if you are concerned to design). Font style is loaded correctly but is not the same as the design also. You should have a look at some CSS transitions animations here https://freefrontend.com/css-menu/ and here https://fireship.io/lessons/css-responsive-icon-navbar/ to keep practicing 👍

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Sir, I think this is a good job, well done! 👏🎉 What you can do to make it perfect is fixing those accessibility errors, giving the input the aria-label attribute is a good start... I forget these things as well...

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey I like your solution!

    I recently discovered another way to write this markup, It might be the best way to go next time

    <details>
<summary>How many team members can I invite?</summary>
<p> bla bla bla </p>
</details>

    cheers

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    You're not far from design, maybe just a better understanding of sizes and dimensions, that footer got you a little bit higher (we have to make the designer happy) this slider comparison up here helps to see our mistakes. It just takes time though, so keep practicing! Great job 👍

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Good job man!

    From what I can notice here maybe try to fix that <nav></nav> element, give it some align-self so that when you hover on the link it's not jumping too much

    and try to make the telephone number and the email address on the footer links you can click

    Keep practicing 👍 :)

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    countries = is my res.json() how can i filter from that for each of those alpha 3 code thank you i'm on the tutorials anyway :)...

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    I'm trying to create a function i know i'm really bad at it :)

    const borders = country.borders; const fullName = for(let border of borders){ let name = border.name //i know this is wrong return name });

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Ok transform: scale(), i will try it out, the part i'm not 100% happy with, it was just that concerning with the design it was not 100% identical, which is something definitely possible, i actually went back to it and made a couple of adjustment (to track my mind as well i duplicated those svg with a orange replica, used "aside" tags for more semantic html, and actually to fix the "a" accessibility errors i have put in there aria-label="" and title="") perhaps i could have cleaned that glider code a little bit more to make the whole thing a little less heavy. We are working on it :).

    Thank you for your time!

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey don't forget the input must have a label :)

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Thanks you for your help Matt!

    I appreciate really, these are some good information you are giving me. Mostly it's the Java Script part that is a bit overwhelming over here, but i will go back to this project many times more probably :) and i will try to fix it in the best way possible, i will!

    I should avoid html mistakes now...

    Thank you again!

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey Matt, thanks for your suggestion it is something i have to go back to

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hi, is it just me or when I click on the button the page kinda goes refresh?apart from that maybe some small adjustments how's looking for you?

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey Matt! Thanks! as always great suggestions. Ill'keep that in mind, i have to make sure everything is in place before submitting a solution :)

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    Hey Matt, thanks! yeah i shouldn't be bothered too much with adding an extra media query when needed, unless there is another way around.. thanks you're providing great coding lessons !

  • Vincenzo Marcovecchio•1,195
    @VincenzoMarcovecchio

    hey man thank you for replying to me, you made my day, it's definitely something i have to practice and understand better :) thank you