Latest comments
- @Msindy@adeleke5140
Hi Misindy, great submission. I looked through your codebase and it seemed that the styles for the
heading
andtext
did not apply. This is in reference to thefont-weight
andwidth
properties. Also it doesn't seem like thefont-family
was applied. You should check them and see why they aren't working.What do you need help with in regards to media queries?
Marked as helpful - @clarencejulu@adeleke5140
Hi Clarence, Your readme is very detailed. Great work on that.
I checked out your repo and I saw that you pushed your
node_modules
folder to github. It's always recommended to ignore thenode_modules
folder.To do that for your next project, ensure you add
/node_modules
in your.gitignore
file.Marked as helpful - @MarcinFiuk@adeleke5140
I visited the preview link and an error keeps showing. It says: "I'm Sorry But Something Went Wrong. Code:0"
What could be wrong? if you feel like sharing, I'd be willing to help out.
- @ovie009@adeleke5140
Of course, you are allowed to make as many modifications as you like.
- @cbserra
REST Countries API (React/react-select/Dark Theme/Responsive UI)
#accessibility#fetch#react#typescript@adeleke5140Great project.
A couple issues I noticed from the live preview are:
- The theme text doesn't switch, it stays as dark mode.
- the fading that occurs is a bit too slow. I know you were going for a smooth transition but I believe that can be improved.
You mentioned using React-select, how about trying out the native HTML select form control?
Marked as helpful - @BryanFonseca@adeleke5140
Have you tried looking into the HTML and accessibility issues that was generated??
They are one way of improving your webapp. And Redux might not really be necessary unless you need that global state. In my attempt, I used prop drilling but moving forward, I'd be employing Context to keep things clean and readable.
Marked as helpful