M21• 180
@mohamadc21
Submitted
Danny A. Mase
@admase
All comments
- Danny A. Mase• 200
@admase
Posted
Hi, I recommend a container within the class name 'country' or outside to center the country flag and details instead of the big gap in between the contents, also increase the width and height of the flag there's is plenty of space to fill in. I would suggest filtering the regions in ascending order when a user selects an option. Lastly, have a footer with copyright, license, and a link to your Github page for people who find interest in your work. Include comments in your code. Overall very nice work, about 4 to 5 pages of code, if I was to utilize ReactJS I would've created a component for each piece of data fetched from the API. Thanks for sharing.
Marked as helpful
0 - Sandro Tsertsvadze• 430
@Sandrex233
Submitted
Danny A. Mase• 200@admase
Posted
Your project wasn't as close to the design example, with the dark and light modes, and some minor issues with setting a default width and height for the countries. Overall, you did great with the JavaScript code executed with no errors and great use of the react.js framework. I recommend learning CSS3 to better position content on your webpage.
Marked as helpful
0 - JibbyCodes• 290
@Kijimai
Submitted
I really enjoyed working on this project since it taught me so much about what I could do with vanilla javascript. I still had issues with properly placing elements on different breakpoints but it was a helpful challenge regardless.
Danny A. Mase• 200@admase
Posted
Great effort, it still looks good. As you stated, the issues are with the position and alignment of elements. I think if you increase the width and height of the images, other elements could fall in place with the solution. Good job!
Marked as helpful
1
