Skip to content
OverviewSolutions
8
Comments
9
P
Kumani Kidd
@amancalledkidd

All comments

  • P
    Matthef•190
    @MatFrat95
    What are you most proud of, and what would you do differently next time?

    This was very problematic project, from the very beginning I faced multiple problems with particular elements, mixins, responsiveness and much more. The most important fact is, I solved all of those problems and learn a lot from my own mistakes.

    Besides that, I know also what should I improve to write better code, I will implement knowdledge i obtain here in upcomming projects to create code easier to read and edid and more reusable.

    I also implemented mixins with variables and used scss to divide code between separate files, thats very handy. Ill try to use more varibles other than colors in next projects and clamp() as font size unit.

    What challenges did you encounter, and how did you overcome them?

    I had problems with:

    • using mixins to with variables included, it was hard for me tu understand why my code was not overwriteable for @media (found out I had to put images to separate section)
    • correct order of files in workspace which cause problem with emulating site via github (trial and error)
    • responsivenes of site obtained by flex and grid used as mixins I'm sure there was a lot of other problems but those took me the most time to fix on my own.
    What specific areas of your project would you like help with?

    Can i use 'margin: -3rem;' to move element up? And .. why I can't see picture from footer here and I can see it on live server? Besides that I will appreciate if anyone give me any feedback :D

    Meet landing page SCSS Grid/Flex

    #sass/scss
    1
    P
    Kumani Kidd•170
    @amancalledkidd

    Great work - the landing page looks great, matches the designs and is completely responsive!

    • Good use of semantic html. I would recommend using the <header> and <footer> tags instead of a section or div as this helps screen readers.

    • Code is well structured, well done with the mixins and seperations of scss. Also with the comments it is very readable.

    • negative margins can be useful to get content in the right place but can lead to issues on different sizes screens

    • In regards to the footer img, this is happening because (line 44 inside _media.scss) background-image: url(../../starter-code/assets/desktop/image-footer.jpg) the url is incorrect as you have an extra ../. What you have written is correct if using _media.scss directly. But because the css is being called inside style.scss which is a level up it does not need the extra ../.

    Again great work, hope this feeback helps!

    Marked as helpful
  • Iryna Kokolius•120
    @ikokolius
    What are you most proud of, and what would you do differently next time?

    Getting experience with CSS Grid and BEM naming convention

    What challenges did you encounter, and how did you overcome them?

    Getting everything as close as possible to the designs

    What specific areas of your project would you like help with?

    I would be really happy for any tips on how my solution can be improved, thank you.

    Responsive Mobile-First Testimonials Grid Section

    #bem#sass/scss
    1
    P
    Kumani Kidd•170
    @amancalledkidd

    Great solution, looks good!

    • Good use of semantic Html and BEM
    • Layout looks great on all screen sizes!
    • Structure of code is really good, use of sass and seperation on stylesheets makes code readable and resuable.

    Great work!

  • P
    Kumani Kidd•170
    @amancalledkidd

    Great work on the solution!

    Good use of semantic html, in future try to avoid use of div as a header <div class="header"> instead you can use <header> as it better for Seo and accessiblity. Also include an alt text for images for accessibility.

    Layout looks great on mobile and desktop.

    Code is well structured, SCSS use is great! The different stylesheets make code very readable.

    Overall great job on the solution, hope the feedback helps!

  • NeonCodes•60
    @NeonCodes
    What are you most proud of, and what would you do differently next time?

    I am proud that I managed to use media queries to change the layout of the page according to the screensize.

    What challenges did you encounter, and how did you overcome them?

    I had trouble using the picture element. But after watching a tutorial about it(one of the resources in the README), I applied it to this project.

    What specific areas of your project would you like help with?

    Any advice on accessibility (I'm not sure the aria label and aria labelledby are being used correctly) or how to use Sass efficiently.

    Product preview card using flexbox and Sass

    #sass/scss
    1
    P
    Kumani Kidd•170
    @amancalledkidd

    Good work!

    • The solution includes great use of semantic HTML!

    • Accessiblity is good, using alt and aria labels

    • Solution looks good on desktop, mobile is okay but needsa a few adjustments. You have used display: flex on the button element, which is causing it to change shape. Try taking it out and seeing how the button looks.

    • Code is well structured, good use of comments for readability and good use of variables for colors and fonts making reusable.

    • Solution is very similar to design, a few adjustments and it will match completely.

    Overall great job! Try using sass nesting as it makes the code more readable for other users see example below:

    CSS
nav ul {
  margin: 0;
  padding: 0;
  list-style: none;
}
nav li {
  display: inline-block;
}
nav a {
  display: block;
  padding: 6px 12px;
  text-decoration: none;
}

    SCSS
nav {
  ul {
    margin: 0;
    padding: 0;
    list-style: none;
  }

  li { display: inline-block; }

  a {
    display: block;
    padding: 6px 12px;
    text-decoration: none;
  }
}

    Hope that helps!

    Marked as helpful
  • P
    Kumani Kidd•170
    @amancalledkidd

    Good job, finished works looks like the designs.

    HTML code is well structured and uses semantic css.

    I would recommend using class names, it's good to get used to using and writing them as they are important for managing css as the amount of code gets bigger.

    Layout looks good on different screen sizes.

    Marked as helpful
  • P
    Kumani Kidd•170
    @amancalledkidd

    Looks good, very close to the designs provided. I like how you have added your own details

    Could use Semantic HTML to improve accessiblity.

    Code looks well structured.

  • P
    Kumani Kidd•170
    @amancalledkidd
    What are you most proud of, and what would you do differently next time?

    Utilising the css variables and media queries. Next time I will try to make variable selectors more efficent with less code. Also will focus on building mobile first in future

    What challenges did you encounter, and how did you overcome them?

    Using semantic elements to improve accessiblity. To help I looked at best pracices online

    What specific areas of your project would you like help with?

    Any image sizing tips?

    Responsive Blog card using css variables and media queries

    #bem#accessibility
    2
    P
    Kumani Kidd•170
    @amancalledkidd

    Thank you very much @huyphan2210. This advice is really helpful! I had no idea there was a picture element, will be putting this into practice on the next challenge - Thank you again!

  • P
    Steven•180
    @stevensuna
    What are you most proud of, and what would you do differently next time?
    1. Design Token Implementation
    :root {
  /* Systematic approach to storing design decisions */
  --color-yellow: hsl(47, 88%, 63%);
  --font-size-base: 1rem;
  --spacing-md: 1.5rem;
  --card-width-mobile: 20.4375rem;
}
    1. Mobile-First Approach
    /* Base mobile styles */
.card {
  width: var(--card-width-mobile);
  padding: var(--spacing-md);
}

/* Desktop overrides */
@media (min-width: 48rem) {
  .card {
    width: var(--card-width-desktop);
  }
}

    Key Learnings

    • Structured design tokens for maintainable CSS
    • Mobile-first responsive design principles
    • CSS custom properties for flexible theming
    • Progressive enhancement workflow
    • Systematic spacing and typography scales

    Blog Preview Card using HTML & CSS

    #accessibility#materialize-css
    2
    P
    Kumani Kidd•170
    @amancalledkidd

    Amazing job, look identical to designs and code is written clearly with understandable notes.

    Great use of variables makes the project very scaleable.

    Semantic HTML and use of alt makes code accessible.

    Great work!

  • P
    Kumani Kidd•170
    @amancalledkidd

    Structure of container looks good and styling matches mostly design.

    Semantic HTML would help improve accessiblity.

    Class names and styling look good and reusable.

    Image is missing, check the src of the <img> element and compare it to the location of the image.

    Marked as helpful