Aryan Kumar
@aryanda1All comments
- @ersinydnn@aryanda1
No mobile design, everything overflowing NO check for empty comment No relative time formatting able to increase or decrease score more than 1 No overlay and modal for deleting comments
Marked as helpful - @Jaimayal
Interactive Comments built with Astro + React + Tailwind + Nanostores
#astro#react#tailwind-css#typescript@aryanda1Well many things were off, first of all, didnt checked single thing before submitting a new comment or editing a new comment, a empty comment. Also there was no border radius on any containers.no visible border in textarea without clicking. ANd once the reply and edit forms are open, not able to close them, without submitting, Able to increase or descrease score of any comment more than 1. Did u rushed to complete it?
- @leqsar@aryanda1
animations looked good, but footer was missing, in mobile version, the green line was not made vertical
- @berkedemirell@aryanda1
Well there are many issues in the frontend part, first your mobile layout is different, and many things start coming out of their parent The green line is missing in the advanced stats part The original link is not hidden , and also less padding
- @guill52@aryanda1
Hey the hover effects are missing, If u are having difficulty in adding it, first make those span hidden, than use javascript to add event listener to detect hover state and make them visible,
- @3eze3@aryanda1
Didnt checked days in month Getting negative day for 31, april as well as -1 day for 30 feb Also your layout broke in my android phone, days are coming out of their parent container
- @IThower@aryanda1
With less height your layout just breaks, the email address field along with its label detaches from its parent, the side image is also not responsive, does resizes itself according to parent. Also in the mobile version dont add border-radius to the main-container And u are serving same image in mobile version as well as desktop version. Also the list item icon are not in line with the item content ANd in moble version, there is no black background as well
And for small projects, no framework is really needed
- @jameswhatley@aryanda1
Just want to give one feedback, sometimes the advice sent by back api, gives same advice, u can check that out and call again until new advice is supplied
Marked as helpful - @Marvel08-tech@aryanda1
Man first the main card is also vertically centred in desktop mode, Second add atleast cursor pointer to buttons, and some hover states to them atleast
- @Belly606@aryanda1
Bro where is the mobile version, i cant find it? I looked in the challenge page and i saw the mobile version where the rating are just below main text, but your rating are off the scrren and screen width is also quite more.
Marked as helpful - @birkirfreyrg@aryanda1
Man for this tiny project do u really needed react? Also the gray color just below the image, in the crevices of the circular border doesnt looks great, THe bottom container has white color, and the spaces created by border-radius has gray color and it looks quite bad
- @guill52@aryanda1
Hey your ui looks horrible after 375 px, there isnt width for u to trigger desktop mode just after 375px
- @gguilhermelopes@aryanda1
HEy man. Everything is fine. Just had one question where u are storing the user details, like how u are sending the tasks from backend to frontend without any signup, and i dont see any kind of id getting stored in localstorage, or in cookies or in session storage. SO how did u completed it?
- @tomkrieg108@aryanda1
Well u missed one thing also, the delete button on each item is always visible in mobile mode Also the hover on buttons are absent
- @AlexMagargiu@aryanda1
I noticed two small problems first cant add completed task second the way u implemented drag and drop is weird. Normally the draggable item will be placed the position were it was dropped rather than on some place else, And its consantly getting dropped as i move up or down, And like u saved the theme, u can also saved the todos also Now encountered third problem, when i removed all items using clear completed, now i cant add any new item, enter doesnt adds any item, but clicking the svg icon removes input value but doesnt adds it, also when in active tab, u can remove the ticked todos, and same goes for the completed tab The bottom three buttons which appear in mobile mode appear differenlty now, WHen i go from desktop to mobile and again to desktop they dont merge with the last row which contains item left and clear completed button And that Challenge by Frontend Mentor. Coded by Magargiu Alexandru Razvan. should be placed at bottom of all your content, rather than on your main content. ANd also by deleting items, why the top images starts to come down?
- @dereck445@aryanda1
WHen i click decimal, nothing gets updated on the screen, only after when i click another digit it gets diaplayed. ANd also when i click decimal multiple times, than nothing happens, no digit gets added afterwards
Marked as helpful - @breeMudi@aryanda1
Your calculator is missing some logic, like when i do some operation and than i click equal, it results to the number. But afterwards if i click a digit, the old number should be erased, rather than appending to old numbers
- @stpholise@aryanda1
Your calculator was showing empty when i did 0/0, and when i chained a subtraction sign, it was showing negative sign on top, but only that ANd your del key is going out of its button when viewed at 375px width.
Marked as helpful