I'm most proud of the entire thing, this was pretty challenging. I tried to make it so only stuff needed are dynamic, and share data among components using stores.
Austin
@astnioAll comments
- P@hikawiWhat are you most proud of, and what would you do differently next time?P@astnio
I like your solution a lot! It seems very polished. It was also nice to see you using stores, this is something I am still learning myself and it was nice to see a demonstration of them being used here.
- @Leeh27What are you most proud of, and what would you do differently next time?
De mesmo com as dificuldades ainda conseguir ser diferente dos outros e tentar sempre mudar o design dos desafios.
What challenges did you encounter, and how did you overcome them?Responsividade. Ainda não superei kkkk
What specific areas of your project would you like help with?Ainda tenho dificuldades com responsividade.
P@astnioI like your custom layout, it's very creative! However, I noticed that the design is not responsive, and the mobile menu is not working for me, either.
- @cassiopeia001P@astnio
This looks great. I noticed that you used regex to validate your email, too. I think that is really cool, as it is something I have wanted to delve more into. You have inspired me to play around with that more in future projects.
Marked as helpful - @SJK9476P@astnio
Your code looks good to me, and your HTML is semantic and your JS is concise. The only issue I can see right now is that your format is quite a bit different from the example. This may just be nitpicking, but the example had a larger title, and your attribution was left unedited too. Otherwise I think it looks great!
- @alphastand27P@astnio
Your solution looks quite sophisticated, and I like how well you document your code! I will say that I feel as though choosing not to use a form for the radio buttons may go against best-practices of using semantic HTML. I can see you tried, but it may prove to be an accessibility issue if this were implemented in a more complicated environment.
Marked as helpful - @jacksonwhitingWhat are you most proud of, and what would you do differently next time?
I tried Qwik for this project. It's a great framework and I'm interested to see how it develops. Builder.io is doing great things. Lots of potential with Qwik.
What challenges did you encounter, and how did you overcome them?I find that the more I try different frameworks the more I see similarities and it becomes easier to switch.
P@astnioI have never heard of Qwik before, and it was interesting to check it out. It looks like a very cool framework! I also find your approach of having each question/section be a seperate page. While it feels a bit choppy as a user, I can imagine it is a much simpler developer experience to go that approach.
- @jacek8depaP@astnio
I think this looks pretty good, overall. One thing I noticed is that your "copied" text does not come up when you click on the copy button.
- @codesByJoseWhat are you most proud of, and what would you do differently next time?
WHat i learnt is to refactor code, writing codes in the raw-rest form and then making them reuseable is what this project has taught me. It also taught me that solving problem is a step by step thing, and i am glad i learnt and scaled through.
What challenges did you encounter, and how did you overcome them?I am looking forward to writing more and more reuseable codes. I used a lot of attributes i dont know if that is ok but id be looking forward to better ways to using less attributes.
What specific areas of your project would you like help with?all feedbacks are highly welcomed
P@astnioThis looks pretty good, in my opinion. One thing in particular that stood out to me is that you have a height: 100vh set on your body. I had received feedback once before that this is bad practice, and it is better to set it to a min-height instead.
Marked as helpful - @tunaertenWhat are you most proud of, and what would you do differently next time?
I didn't have much trouble with the CSS part. I got stuck a bit on the colored part of the cards. Initially, I did it using a pseudo-element, but then I changed it later. This part took some time. It was quite a fun project.
What challenges did you encounter, and how did you overcome them?In the JS part, rendering the view also took a while. In my first code, I could see the view when I clicked on the daily or weekly section, but when I loaded the page, the activities didn't show up. However, I realized I only needed a single function I hadn't noticed. I think I won't get stuck on this part for so long in my future projects.
P@astnioThis looks great, your JavaScript is much more concise than mine was!
Marked as helpful - @RaviCoderWallahP@astnio
Your solution looks great, everything works seamlessly. Your HTML looks semantic and your CSS looks great too.
- P@shpokas-ioWhat are you most proud of, and what would you do differently next time?
Proud that i tried to use as semantic as possible in HTML section , but I think that way is much harder and I don't understand fully why things don't work as they should
What challenges did you encounter, and how did you overcome them?dekstop version not working properly, instead of two column horizontal it is mobile one column, in mobile aspect of it doesn't pop up share section
What specific areas of your project would you like help with?THere is alot of problem with this one but i`ll just raw dog it and leave it for later fixing
P@astnioSeems as though you are already aware, but this does need quite a bit more work done in getting the layout configured.
I do like what I think you were going for, however. In particular the animation you setup when clicking the share button. It isn't working fully now, but I can see what you were going for and I really like it!
Your HTML also looks really good, just some more work on your CSS and I'm sure it will all come together.
- @MsadafKP@astnio
I think this looks really good! Your CSS and HTML seem to be more concise than mine. The one thing that really stood out to me was that your circles with the numbers are more like ovals. The way I solved this for mine was by adding
aspect-ratio: 1
to mine. - @luisgustavogorniakP@astnio
I noticed that you used grid area to setup your layout. That is really cool, I did not know you could use grid like that! I will keep that in mind for my future projects.
- @RohloffmeisterWhat are you most proud of, and what would you do differently next time?
The responsiveness
P@astnioThis desktop view of this looks really good. Though if I had to nitpick, I would say some work is still needed in terms of spacing and sizing.
The only real issue I had was the mobile view. There, some of the icons overlay atop the text, making it difficult to read.
One of the easier ways to test your mobile layout would be through your web browser. If you go to inspect the page, you should find an icon that looks like a phone and a tablet stacked atop each other. If you click on that, your browser will show you what your site looks like on mobile. Using that can make it easier to develop your mobile view.
Marked as helpful - @eduardoe92P@astnio
This looks well done! All I have noticed is that the mobile view is not centered like the desktop view is. I noticed that your desktop view has a top margin added to bring it down from the top of the screen, while your mobile view lacks that. It may also be related to the total height of the viewport, as the box containing your card is only as big as the card within it. I would suggest either adding more margin to your mobile view, or adding size to your body element.
- @odevlucassP@astnio
This looks great! The one main thing I noticed right away is that the cursor is a bit inconsistent, just in regards to it changing to the "hover" state when hovering over a link. I noticed that it only changes when over the text, and not the whole link, despite the background changing. The one thing I would have done was styled the entire <a> element so the whole button can be clicked, instead of needing to click on the text specifically.
- @nathan-barkP@astnio
Your solution looks great! Your CSS and HTML is very concise.
- @anderjackieWhat are you most proud of, and what would you do differently next time?
To finish the project and to get to understand how the tags were composed.
What challenges did you encounter, and how did you overcome them?Definitely the responsiveness of the component. But when I set the min and max of the height and width everything went fine.
What specific areas of your project would you like help with?Which html tags are proper to use in this case.
P@astnioThis looks great, seems like you did a really good job. Maybe just a nitpick, but the design had 3 lines for the paragraph, while yours only has 2. I was able to achieve that for mine by setting a max-width on the paragraph's container.
Marked as helpful