Skip to content
OverviewSolutions
35
Comments
45
Bhremada Fevreano
@boedegoat

All comments

  • Bhremada Fevreano•1,395
    @boedegoat

    Nice one @AditNovadianto. One thing is missing. You should make the mobile navbar close when the user clicks outside. And don't forget to fix the accessibility issues. As always keep it up and enjoy coding 🔥

  • Bhremada Fevreano•1,395
    @boedegoat

    Nice one @AditNovadianto. I like the blur transparent effect on the mobile nav opened. Also, try to fix all those accessibility issues. Keep it up 🔥

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good work @madegilangaditya. The design is pretty neat and responsive as well. To get rid of those accessibility issues, you can wrap all of your components with a <main> tag. Also, I think it would be nicer if you make clicking outside will close the mobile menu or modal. Other than that, keep it up and enjoy coding.

  • Bhremada Fevreano•1,395
    @boedegoat

    Very good @AditNovadianto!

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Great job @AditNovadianto, I like how you implement those animations to make the site more live. Keep it up and enjoy coding 🎉

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Nice work @AditNovadianto, Just remainder, kindly check the issues there and there is some kind of weird gap in top part, try remove the vertical padding in your container. Other than that, keep it up and enjoy coding

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Nice work @AditNovadianto, as above comment said, try fix those accessibility and layout issues. Other than that, just keep doing more project especially with react so you can get more better and better.

    Keep it up and enjoy coding

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Great work @AditNovadianto. The result looks really great and its responsive as well. I think you getting better. So keep it up and enjoy coding.

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Great work @AditNovadianto. You've done fantastic work.

    Just remainder, take a look at your accessibility issue, try to fix it by wrapping your entire app with <main> tag. Also, I think that mobile menu should be closed when user click outside it.

    Other than that, keep it up and enjoy coding

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Great work @besttlookk. The result looks really great.

    But there is one small issue, the mobile menu is kinda pushed to the right on <375px screen size so it's not responsive yet.

    I think it's because the inset property in MobileNavigation_Wrapper, on what I have tried before, deleting inset and adding these styles may fixed the issue :

    top: 0;
right: 0;
width: 180px;
height: 100%;

    Other than that, keep it up and enjoy coding

  • Bhremada Fevreano•1,395
    @boedegoat

    Great work @AditNovadianto. Congratulations for finishing another challenges.

    Some of your issues have been explained by @Prabhash Ranjan. So I suggest you to learn more about the usage of max-width to make your layout more responsive.

    Other than that, keep it up and enjoy coding !

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good job @AditNovadianto

    One thing to note, you might use <main> tag to be the container of your app in order to fix those accesibility issue.

    Other than that, keep learning and enjoy coding ☕

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good work @AditNovadianto

    One thing to note, it seems you forgot to make the mobile style for the app.

    Other than that, keep learning and enjoy coding ☕

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good work @AditNovadianto

    To address those ACCESSIBILITY issues, add <main> tag to be the container.

    Other than that, keep learning and enjoy coding ☕

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Great work @naufalf25

    You did the project pretty good. The rating system works well. But, it seems like you forgot to handle a case where user is immediately click on submit button without selecting any rating. As a result it will display 'You selected undefined out of 5'.

    Other than that, keep learning and enjoy coding ☕

  • Bhremada Fevreano•1,395
    @boedegoat

    Good job @AditNovadianto

    You did it pretty good. I like the shake animation when user is not selecting any rating.

    keep learning and enjoy coding ☕

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good job @Marianodsad

    It seems like the background images are repeating which is not very good. Here's how you can fix that :

    background-repeat: no-repeat;

    Add that property and the problem should be fixed.

    Other than that, keep learning and enjoy your coding journey ☕

    Marked as helpful
  • Bhremada Fevreano•1,395
    @boedegoat

    Good job @AditNovadianto

    The form is working great and you have no issues at all, that's really nice. But it seems your responsive layout is not doing good. Even for 375 px, the layout is overflowing. So I really suggest you to fix that and learn more about how to make things have better responsive.

    Other than that, keep it up and happy coding ☕

    Marked as helpful