Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @willengarcia

    Submitted

    What are you most proud of, and what would you do differently next time?

    Me orgulho de ter conseguido fazer esse desafio, pra mim, apesar de ser simples, tive algumas dificuldades, porém consegui superar algumas delas, tais como o uso do JS, e o desing responsivo para do drop-up ficar bonito.

    What challenges did you encounter, and how did you overcome them?

    Responsividade do leiaute

    What specific areas of your project would you like help with?

    nenhuma

    P
    Branka R 160

    @brainka

    Posted

    Goos job on your project!

    The responsiveness is working pretty well :)

    0
  • P
    Michael 250

    @Mlchaell

    Submitted

    I wasn't sure how to do the hero image properly so they are there, but the sizing/placement isn't right. If anyone would have any ideas let me know!

    Thanks

    P
    Branka R 160

    @brainka

    Posted

    Hey!

    Really good job with the project.

    I would suggest looking at css position property. This is how I managed to move the placement of the images.

    Question: Why did you not use the <img> element instead of showing the image as a psuedo element?

    What you could do is wrap the hero image/s in an <img> element then add for example: position: relative top: -10px

    This will move the image from its position down by 10px.

    You play around with this with your section class="img-grid" container to see how it works!

    Hope you find this useful 😀

    Please let me know how you go!

    0
  • P
    Branka R 160

    @brainka

    Submitted

    What are you most proud of, and what would you do differently next time?

    Proud that I managed to get the desired grid layout.

    Next time, I would plan it out ahead of time before starting the code.

    What challenges did you encounter, and how did you overcome them?

    I resort to using flex by default, so made myself use grid for the entire layout.

    No issues, just need more practice using grid layout.

    What specific areas of your project would you like help with?

    Just overall code review and one question.

    I understand that the accessibility report is highlighting that the page requires a single h1 tag.

    In this instance, this isn't really a landing page, but another section and this is the reason I have not added any h1 elements.

    Is this correct?

    Thank you

    P
    Branka R 160

    @brainka

    Posted

    Hey,

    Thank you :)

    Will consider that for sure!

    0
  • @Tayara97

    Submitted

    What are you most proud of, and what would you do differently next time?

    .

    What challenges did you encounter, and how did you overcome them?

    it was challenging for me when i start with mobile-first but i did it well

    What specific areas of your project would you like help with?

    ..

    P
    Branka R 160

    @brainka

    Posted

    Good work!

    1
  • P

    @fish-ladder

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud of going a step further with the responsive design and adding a mid-size screen breakpoint with a third layout of the 4 cards.

    I was also proud to accurately dial in the little colored accent lines at the top of each card and get the box-shadow effect very close to the design.

    Next time I will try to pace myself better. I got a bit manic with my styles and started getting sloppy with writing my code. This made more work for me later in tidying things up.

    What challenges did you encounter, and how did you overcome them?

    I had a much harder time getting the colored accent stripe right on the top of each card. I first tried just a top border but it didn't look right. Then I tried creating a separate div inside the card but that didn't achieve the right look either. Finally, I created a linear gradient in the background and I think that did the trick.

    I also spent more time that I would have like tweaking details like margins and padding in the desktop layout.

    What specific areas of your project would you like help with?

    In terms of layout and sizing, where is it OK to use absolute units like px and when should I be using em or rem?

    P
    Branka R 160

    @brainka

    Posted

    Hey,

    Really good job on your project and the way you have structured your html and css 😄

    I don't like to just paste links but I find this explanation very useful when I forget when to use px, rem or em haha ===> EM vs REM vs PX.

    Hope this helps!

    Good job again 🥳

    Marked as helpful

    1
  • ajkun55 490

    @ajkun55

    Submitted

    What are you most proud of, and what would you do differently next time?

    all

    What challenges did you encounter, and how did you overcome them?

    ok

    What specific areas of your project would you like help with?

    ok

    P
    Branka R 160

    @brainka

    Posted

    Hello!

    Nice job! The comparison is really close :)

    I have noticed you used margin to add spacing to your text div.

    What you can do instead is add padding next time. Padding is used to create space around the content, where as margin is used to create space between elements.

    Just something to keep in mind for next time!

    Again, really good job :)

    Marked as helpful

    0
  • @ralrafie96

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am glad I could structure the document into elements effectively

    What challenges did you encounter, and how did you overcome them?

    I was unsure how to properly style and structure the list items and table components

    What specific areas of your project would you like help with?

    None for now, I feel comfortable with the project so far

    P
    Branka R 160

    @brainka

    Posted

    Hey!

    Just a tiny note. Consider splitting your html and css files separately. It makes it easier to read and won't clutter the html file :)

    Otherwise, good work on the component :)

    0
  • Srithar_K 150

    @SritharanKalimuthu

    Submitted

    What are you most proud of, and what would you do differently next time?

    Nothing

    What challenges did you encounter, and how did you overcome them?

    None

    What specific areas of your project would you like help with?

    Nothing

    P
    Branka R 160

    @brainka

    Posted

    Keep up the good work! Looks pretty spot on!

    Marked as helpful

    0
  • Cristian 80

    @DevCris05

    Submitted

    What are you most proud of, and what would you do differently next time?

    el poder hacer uso de las tecnologías de HTML, CSS y JavaScript para poder completar este proyecto

    What challenges did you encounter, and how did you overcome them?

    al momento de poder hacer encajar la imagen a la altura que esta requiriendo en el diseño

    What specific areas of your project would you like help with?

    Al momento de hacer :hover sobre el texto la tarjeta cambie su sombra y sin hacer uso de javascritp

    P
    Branka R 160

    @brainka

    Posted

    Hello!

    When you use hover to change the stage of an element, such as the H1 title card in this project, you don't need to use Javascript for this.

    The requirement was to make the text change colour when you hover over it.

    The reason the box shadow is changing in size when you hover is because you have included your javascript logic as well.

    You can remove the main.js and **

    0
  • P
    Branka R 160

    @brainka

    Posted

    Really good work on the component.

    I would suggest to take another look at the design requirements and try to update the styling as close as possible.

    I would suggest to update your heading from H3 to H1. A page must contain 1 H1 heading.

    I would also update the paragraph to a larger font size.

    With these 2 changes, the height of the QR component should be a lot close to the design.

    Let me know how you go!

    I would also update the paragraph color

    0