Skip to content
OverviewSolutions
13
Comments
13

Branka R

@brainkaAustralia290 points

Wanting to start generating actual output for all the things I have learnt to date. Need to move away from theory and watching courses all the time and start making things!!!!

Latest solutions

View more solutions

Latest comments

  • Achara Chisom Solomon•490
    @AcharaChisomSolomon
    What are you most proud of, and what would you do differently next time?

    Whewww!!! . . . . This looked deceptively simple at first, definitely worthy of being an intermediate ranked project!!!

    getting the strength display was fun and is what I am most proud of.

    What challenges did you encounter, and how did you overcome them?

    A lot like figuring out how copying to the clipboard works, determining the strength of a password using regex and the css tricks involves, and also overriding the default styling for html input elements.

    loads of googling and chatgpt helped.

    What specific areas of your project would you like help with?

    nothing for now!!!

    Any tips to improve is welcome

    Password generator app

    2
    Branka R•290
    @brainka

    Hey!

    I totally agree, it was very deceptive but equally great and challenging.

    Really good job on this project :)

  • Graeme Byrne•520
    @grmbyrn
    What are you most proud of, and what would you do differently next time?

    Getting the JS to all work together.

    What challenges did you encounter, and how did you overcome them?

    I found the layout of the project a little strange. Having an error message appear when there isn't a button to press to make the calculation was a little odd for me. I left it out.

    What specific areas of your project would you like help with?

    I would like any advice on how to get the bill, tip percentage, and number of people info and how best to calculate the tip amount and total as I think I could improve that.

    Tip calculator

    1
    Branka R•290
    @brainka

    Hey! Nice work on project.

    From my observations, your calculations appear to correctly calcualte the tips, so I don't believe you need to change anything there.

    Just a few items of note:

    As a user going through your form, I notice that the tip amount and tip total only evaluate when you click on the select tip % button or when you enter a custom amount.

    Which means, when the user enters in the Bill, selects the tip % and enters the number of people... nothing happens....the user has to then go back to click on the select tip % in order to have the total evaluate.

    I would consider adding an additional event listeners to your other input fields (just like you did with the custom tip field), so when the user types or updates their values, the form will also be updating the totals.

    Hope that helps a bit!

    Happy coding :)

    Marked as helpful
  • Branka R•290
    @brainka

    Hey!

    Nice job on the project :)

  • João Vitor Morita•210
    @joaomorita
    What are you most proud of, and what would you do differently next time?

    I'm proud to use jquery in this project, it was my first "junior" project. I think I can do better my html content, using more semantics tags

    What challenges did you encounter, and how did you overcome them?

    The main challenge was the email validation, I went trought the internet looking for some solutions to overcome this one. The second challenge was give the feedback with colors when the email was invalid, this time I need to search a little bit about some jquerys funcions like "addClass" and "removeClass"

    What specific areas of your project would you like help with?

    I'm looling forward to see some feedbacks about my code in general to improve my skills. Thank you guys!

    Responsive newsletter with jquery

    1
    Branka R•290
    @brainka

    Hey!

    Well done on completing this project :)

    Just a few small items I noticed on your project:

    • You are missing the main element in your html. Your container class should be a main element instead of a div.

    • You have missed adding a background colour to your form button:hover{ cursor: pointer; } when you hover over it.

    Again, good job :)

    Marked as helpful
  • Willen Garcia•170
    @willengarcia
    What are you most proud of, and what would you do differently next time?

    Me orgulho de ter conseguido fazer esse desafio, pra mim, apesar de ser simples, tive algumas dificuldades, porém consegui superar algumas delas, tais como o uso do JS, e o desing responsivo para do drop-up ficar bonito.

    What challenges did you encounter, and how did you overcome them?

    Responsividade do leiaute

    What specific areas of your project would you like help with?

    nenhuma

    Grid, Flexbox, JS

    1
    Branka R•290
    @brainka

    Goos job on your project!

    The responsiveness is working pretty well :)

  • Branka R•290
    @brainka

    Hey!

    Really good job with the project.

    I would suggest looking at css position property. This is how I managed to move the placement of the images.

    Question: Why did you not use the <img> element instead of showing the image as a psuedo element?

    What you could do is wrap the hero image/s in an <img> element then add for example: position: relative top: -10px

    This will move the image from its position down by 10px.

    You play around with this with your section class="img-grid" container to see how it works!

    Hope you find this useful 😀

    Please let me know how you go!

View more comments