crooz• 95
@bobbycrooz
Submitted
It's a beginner level code, where do i need to improve on?
P
Carlos Loureda
@carlosloureda
All comments
- PCarlos Loureda• 150
@carlosloureda
Posted
Hi Crooz! Great start with CSS skills.
I am also new at this site. I was checking your solution and if you see the report that is generated by the site you have 4 accesability issues and 2 HTML issues, check the report here
If you want to check your HTML/CSS validation you can use these online resources:
Tips about folder arquitecture
For these projects it might not be needed but it can be a good training to begin to add .js files into a js folder and .css files into a css or styles folder, you can check a nice medium post about this
Icons Nice addition of _fontawesome` icons, I use them a lot, but for this exercise if I recall it well they asked to use only the assets provided, so in this project you have 3 svg icons provided on the images folder. The result is very nice but for the sake of the exercise I would try to use them, remembe: r that in this industry we will be needing to follow orders from product owners or designers.
Css
Checking out your code everything looks great, good work! I only see you used some ids for styling: #share-icon, #share-icon2. It is recommened to use classes over ids
Design
- I see a little line break between the side image and the content on the right, maybe making the container have the corner borders instead of adding borders to the
card2element would improve that little difference. - If you check the original side image you can see that the right margin is cutting the image at the end of the green table, in my solution I moved the image using:
object-fitandobject-positionGreat overall design and cool code! I am also learning CSS hope these tips help you and don´t hesitate to ask anything!
1 - I see a little line break between the side image and the content on the right, maybe making the container have the corner borders instead of adding borders to the
