@mahidulkabir
Freelance Frontend Web Developer, from Surabaya, Indonesia. I want to help personal and business in their branding process, especially the digital one, through their personal or businesses website. Skilled in HTML & CSS, and marketing strategy.
I’m currently learning...- JavaScript - Node.js - React.js - tailwindcss
Latest solutions
Latest comments
- @christian-prasetya
Nice job, mate, but if I can fix a little bit.
Don't use div as the container, semantically the card is the main element, so maybe better use
<main class="container">rather than<div class="container">as the<div>purpose is solely for styling only.For me is just that, thanks, cheers mate.
- @VitaliySaburdo@christian-prasetya
It's very nice and almost perfect with the solution.
Marked as helpful - @jamilpl@christian-prasetya
Well done finishing this challenge, even though there are some area of improvement can be made.
-
Use the semantic HTML Instead of using
<div class="container">to wrap the whole content, supposed you can use<main class="container">. Because with the right and good semantic HTML, you can fix the accessibility of your website, especially for the user with visual impairment, as the semantic HTML will guide them to enjoy the content of your website. -
In your CSS file, try consistently use 1 unit measurement, like rem, or em instead of pixels. The rem and em will help you a lot when it comes to responsive design. So, in my opinion, you should stick with rem or em units.
Overall it's nice and readable code, and also well-structured (apart from the div container wrapper), I see you trying to implement BEM, but try to look into about it further, you can learn more about BEM here.
Can't wait to see another solution submission from you, cheers mate.
Marked as helpful -
- @bajra03@christian-prasetya
Congratulations @bajra03 for finishing this project wonderfully.
Your code is well structured, semantically correct, and looking good responsively.
Just little bit area of improvement
- Try to apply the measurement using relative units like rem & em, it will help you a lot with the responsive design.
- Try to implement BEM method (Block, Element, Modifier) to create more structured and reusable css code, it will help you a lot in the future.
Once again, congratulations. Matur suksma.
- @okida-rafael@christian-prasetya
Congratulations, mate, for finishing this first project. The result is very good also. You've done a great job.
Your code is well structured, and semantically good. But I see you do not implement any media queries for the responsive design. Please kindly try to add media queries in the future, it will help you a lot in the future project you'll create. And also try to implement more external css, it also will help you a lot in the future.
Cheers, mate.
Marked as helpful - @zakariabelassri@christian-prasetya
Congratulations on finishing this challenge. You structure your HTML & CSS code semantically great and well structured.
But of course there's some area of improvement:
- Try to apply responsive design using media queries, I know it's hard to grasp at the first time, but it's worth it for developing your skill in the future.
- Try to use BEM method for creating a reusable css code that will make your life easier. You can check it here.
- Maybe try to learn about Sass/Scss pre-processor for creating more well structured and modern CSS, it really helps a lot. I just started to implement the using of Sass/Scss and really help me to structured my stylingsheet, and creating lots of functions on CSS. Check it here
But overall, I think you did a great job developing this challenge. Hope to see more finish challenge from you.
Marked as helpful
