Skip to content
OverviewSolutions
25
Comments
7
KamRan
@comendrun

All comments

  • KamRan•370
    @comendrun

    Hi your solution looks great! I really liked that you could match the style exactly like the original design itself! wonderful! but I noticed something I wanted to share with you. You set the height for the main to be 100vh and that's ok, but it can cause problems in some display modes. Probably it's better to set it to be min-height: 100vh; and that would solve the problem. I would like to hear from you about this if you know something that certainly I don't know besides that, I really liked your solution, congrats!

    Marked as helpful
  • KamRan•370
    @comendrun

    Hi Vanza. thank you for your helpful feedback and comments that you write on your projects. I learned a lot from them and also they helped me guide my attention to the right place. Here's my solution, it's not as complete as yours, but I tried and spent a good time on it :

    https://www.frontendmentor.io/solutions/intro-components-using-html-cssflexbox-also-javascript-validation-LbAIqzOu9e

  • KamRan•370
    @comendrun

    Hey Carlos. I hope you're doing well. your solution is good overall but I think you should regenerate the screenshot for your solution because the first one is a little messed up I visited your solution page and it was fine. so you can easily regenerate the screenshot for it to have a better one. wishing you the best of luck

    Marked as helpful
  • KamRan•370
    @comendrun

    Hi! I just wanted to say I really liked your solution. Wishing all the best for you my friend.

  • KamRan•370
    @comendrun

    It really looks perfect Derrick. I accidentally came across your solution and I really loved it. Also, I cloned it as I really struggled in that social media pop-up part and couldn't make it right. I'm sure i can learn a lot of things from your solution. thank you again

  • KamRan•370
    @comendrun

    dear Vanza (@vanzasetia) can you please help me with this? I get a lot of accessibility problems in ReactJS apps and I don't why is it. I tried to read the suggested document about it but I couldn't understand, unfortunately. they're about landmarks on the page

  • KamRan•370
    @comendrun

    Great Job Damilola, I accidentally saw your solution, and honestly, it's a good one. Good Luck with other challenges!