Skip to content
OverviewSolutions
26
Comments
7
Davidson Aguiar
@davidsonaguiar

All comments

  • Davidson Aguiar•320
    @davidsonaguiar

    O sistema nao ficou responsivel, tente adicionar flex box ou grid!

  • Reno G•60
    @pamplito
    What are you most proud of, and what would you do differently next time?

    I'm proud to have completed my first challenge and to have, I think, submitted work that visually looks like the model.

    There's surely a lot of room for improvement and optimization, so feel free to give me feedback so I can do better.

    What challenges did you encounter, and how did you overcome them?

    I only started learning CSS a few months ago so the whole process has been a challenge.

    I have to admit it was a fun challenge but a challenge nonetheless.

    What specific areas of your project would you like help with?

    As a beginner, I would appreciate any advice from experienced programmers.

    However, I would be happy to receive recommendations on best practices for clean and professional coding.

    My first challenge - QR Code

    2
    Davidson Aguiar•320
    @davidsonaguiar

    Hey, dude, what's up? I hope so.

    First, congratulations on the solution.

    Second, I would like to give you a tip regarding the center tag, it is obsolete, so use other tags and center it with css.

    Marked as helpful
  • Davidson Aguiar•320
    @davidsonaguiar

    Hey friend, how are you?

    I noticed that your card is not centered. You can use the min-height property on the body and set the min value to 100vh and use flex box or grid to center it.

    Center using flex box:

    body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

    Center using flex grid:

    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

    Links

  • Davidson Aguiar•320
    @davidsonaguiar

    What's up man, everything's fine. So, I took a look at your solution and missed the use of semantic tags.

  • Davidson Aguiar•320
    @davidsonaguiar

    Necessário usar tags semanticas.

  • Davidson Aguiar•320
    @davidsonaguiar

    good job, Tip: separate your solution into an html and a css file.

  • Davidson Aguiar•320
    @davidsonaguiar

    Muito bom, parabéns. Dica: Teu js ficou muito grande dá pra simplificar. O resultado deu errado quando coloquei minha data de nascimento. Eu transformeu a data atual e data informada em milisegundos e subtrair e depois convertir em anos, meses e dias.