@sukrutikonhar
Submitted
I'd like to know if there is anywhere I can improve on this page.
Looking to hire developers?
@devMagno
@sukrutikonhar
Submitted
I'd like to know if there is anywhere I can improve on this page.
@devMagno
Posted
Hello! 👋 Good job on this challenge!
The layout looks pretty good and it's responsive as well, good job! I loved the tablets and the mobile layout.
I suggest removing the max-width: 1440px
from the desktop media query and adding a max-width to the container instead, because it creates a weird single-column layout on bigger screens. Looking forward to your changes!
Happy coding! 👊
@ble-syn
Submitted
feedback would be very much appreciated!
@devMagno
Posted
Good job on the challenge It looks pretty cool! 🤩
I suggest adding a media query for tablets or smaller desktop devices because the layout gets kinda weird before reaching the 600px media query. In my solution I created a 2-column layout and I thought it looked really cool, so maybe you should try doing that.
Looking forward to your changes!
Happy coding! 👊
@CFlores9812
Submitted
hey if i could get some feedback on the code. Its probably easy to do but i was not able to center the grid container on the page
@devMagno
Posted
Hello! Good joob on the challenge, it really looks pretty good!
To center the grid container you can easily just style the body element like this:
body {
min-height: 100vh;
display: flex;
flex-direction: column;
justify-content: center;
}
Happy coding bro 👊.