@dhdbrud318
Latest solutions
Latest comments
- @dreyfus92
Heyo @dhdbrud318 good job in completing this challenge 🚀. I was reviewing the code and I have a few suggestions:
- It is a good practice that you don't leave your
<form>with a non-empty value you presented<form action=`` class=overlay__modal container` - When you push code into a GitHub repo try to avoid uploading
.DS-Storeand alsonode_modules, this can be achieved by simply adding the names of the directories in the file.gitignore
Marked as helpful - It is a good practice that you don't leave your
- @NoelaOst@dreyfus92
Hello @NoelaOst, good job in completing this challenge 🚀. I was reviewing your GitHub Repo and I have a few suggestions:
- I think that you used a lot of @apply directives which could've been used directly in the classes.
- If you wanna apply a custom font, I think that the easiest way for achieving it with tailwind is using
Fontsourcehttps://fontsource.org/ - And also check the the accessibility report to delve into the problems that you had regarding
landmarks.
Marked as helpful - @musharafaahel@dreyfus92
Hello @musharafaahel good job on completing this project 🚀 ! I was reading your code and I have a few suggestions:
- Using Backslash () used as path segment delimiter is not a good practice, try to stick to (/)
- If use icons as images try to give them an alt attribute describing what the icon is e.g.
src="images/icon-cart.svg"alt="icon-cart"
Marked as helpful - @Have-Samuel@dreyfus92
Good job Samuel, I was reading the accessibility report and I figured out that you're lacking <h1> tags, so I would recommend ya using them when you see a title. Generally, it is a best practice to ensure that the beginning of a page's main content starts with a h1 element, and also to ensure that the page contains only one h1 element. Users of screen readers can utilize keyboard keys to skip straight to the first h1, which should, in theory, let them access the web page's core content.
Marked as helpful - @wlopera@dreyfus92
Lo único que tienes que hacer es poner las media queries, si vas a usar styled components. https://jsramblings.com/how-to-use-media-queries-with-styled-components/ checa este link que explica a detalle como hacer uso de los media queries.
Marked as helpful - @ChromeUniverse@dreyfus92
You can handle validations with tons of tools, like yup, zod if you're using typescript, react-hook-form, formik. Try to read the docs and look for what fits your needs.
