Emanuel Barcenas
@eman2point0All comments
- P@Jayfx24P@eman2point0
Your layout is very nice. I like how you used flexboxes in order to get most of the layout just right. I took a look at how you solved the 2 images on the side of the Group Chat element, and it is a well thought out solution.
Marked as helpful - @Dpolley99What are you most proud of, and what would you do differently next time?
This is the fastest I have completed a frontendmentor challenge. The last one I did was harder than this but it took me about a week to complete that. I did this one in just over an hour. Looks like practicing is really paying me off.
P@eman2point0I would recommend adding more margin to your main content as it is close to the edge of the page.
- @abhishekk0929P@eman2point0
This is a good layout however I would recommend working on the typography regarding the card titles. They seem a bit bigger than expected. I would recommend using em or rem values in order to make the text responsive with different devices.
- P@tobaojoWhat are you most proud of, and what would you do differently next time?
I am proud of how the solution came out, given that I didn't have the figma files.
What challenges did you encounter, and how did you overcome them?Having to guess the layout of this challenge. I had to eyeball what i think the solution would be.
What specific areas of your project would you like help with?If I got the styling close to the original designs.
P@eman2point0.
- P@Herve176P@eman2point0
It seems that your card looks just right but the positioning of it is slightly off. I would say to perhaps get rid of the
position: fixed
for yourmain
element and instead use a flexbox or grid box to center the content.Marked as helpful - @tobiidev21What are you most proud of, and what would you do differently next time?
I'm proud of how fast and easy was this project for me. My skills and my motivation are increasing with every one.
What challenges did you encounter, and how did you overcome them?I haven’t had too many problems during the development process, just a few minor bugs.
What specific areas of your project would you like help with?I usually use flexbox or grid to center some elements, but I’m not sure if it’s good practice. What would you recommend?
- @Shanxx191919P@eman2point0
I would recommend surrounding your
h1
element andp
element with adiv
to make sure they stay inside your box container without bleeding over.<div class='text-description'> <h1> Bold Lettering </h1> <p> Instructions here.</p> </div>
You can then use
display:flex;
to give them even space andflex-direction: column;
to make them line up vertically. - @jeremymouzinP@eman2point0
This is really well done! How did you manage to get the variable text for the name of the product? I was struggling with it.