@wyasyn
Submitted
Looking to hire developers?
@goyal-Dushi
@wyasyn
Submitted
@goyal-Dushi
Posted
Hi , there are few bugs in your application.
BUG 1 : Multiple countries data coming while viewing single country detail
Steps to reproduce
Issue : You will see that the country searched for comes above the country initially present in the UI, instead, it should either get replaced with the new search result or you shouldn't have the search box and filter by region while viewing a particular country detail !
BUG 2 : Neighboring countries not clickable
BUG 3 : Region filter goes away on Back click
After applying region filter, if we select a particular country to view its details and move back using the back button, the previously applied region filter goes away !
BUG 4: Search result vanishes from UI after blur
Looks like CSS issue : After typing any country name inside the search result, if we click outside the search box, the typed value goes away from the input field
Marked as helpful
@Aya-Saeed261
Submitted
Feedback and suggestions are welcome :)
@goyal-Dushi
Posted
I really liked your app. Just have few enhancement you could consider.
@MariaLuisaMD
Submitted
In this challenge I had some difficulties with the DOM and hover states, as well as some specific difficulties in the JS. I had to research a lot on how to solve the problems that arose, it took me longer than I expected to finish, but I found a good challenge. Suggestions on design and how to improve are always welcome
@goyal-Dushi
Posted
It works well, just few UI tips you can consider :
Also, as a bonus, try saving the input values entered by user in local storage of browser so that on page refresh, the values aren't lost. On reset, you can clear local storage.
Marked as helpful
@abdraoufx
Submitted
@goyal-Dushi
Posted
I think you can work on the logic where you are determining the winner. So, in your code I found that you are using switch case statements to implement the logic. I had rather say there is better way to do that.
you can check my solution. I have implemented Rock paper scissor game !
https://github.com/goyal-Dushi/frontend-designs/blob/main/src/pages/RPSgame/components/GameResult.tsx
Marked as helpful
@0marD
Submitted
This was quite a complex challenge for me, but I did it, although I know it could have been done in a better way So any suggestion is welcome.
@goyal-Dushi
Posted
You should use form element for submission of any input value ( present in your HTML validation report) . divs are only used as layout elements. If you don't want to provide any href to a tags, you can use it like this <a role="button" tabindex="0" ...>...</a> or <a href="javascript:void(0);">something</a> or use <span> in case you are unsure of any links to be provided.
It is good practice and increases accessibility.
Rest looks fine!
Marked as helpful
@EmmanuelBalderasB
Submitted
This was a fun one! Any feedback is appreciated and welcomed!
I couldn't figure out how to only let the user select only one option.
@goyal-Dushi
Posted
So, to answer your doubt, you need to maintain a variable state of the button that has been clicked in your clicked function and then, when next time user clicks any button, you need to check if it the same or different button that has been clicked by comparing with the state variable.
Also, use ' ./ ' for you image paths, ( relative path ) , so that it can find your images. Currently on website, images aren't loading !
Marked as helpful