All comments

• 

  Oluwarotimi Akinlua• 30

  @TheCodingArchi

  Submitted almost 4 years ago

  Hi! Stop-start newbie dev here. Looking to add some consistencies to my learning. This is my first challenge, please kindly help review my code and provide some feedbacks on how to write code better. Thanks!

  

  Fylo data storage component using flexbox for layout

  2

  2

  0

  

  Hoe Hooi Yan• 285

  @hoehooiyan

  Posted almost 4 years ago

  Hi there, congrats on your first submission!

  I noticed that you only target the media queries desktop and mobile version. I suggest you can make the logo-icon-card & storage-card stack on each other starting from the tablet size breakpoint.

  For the background image, to make it look better on larger screen, you can set the background property like so:

  1. background-position: bottom center;
  2. background-size: 100% 50%;

  This way, the width of the background image will stretch across the screen no matter what is their size.

  Also, I suggest you write those background property in full name instead of their shorthand, this will increase the readability. So that we get to know immediately which value matches which property.

  Thank you for reading! 😀

  0

  This comment has received 1 replyShow
• 

  jakubfiglak• 400

  @jakubfiglak

  Submitted about 4 years ago

  Hi, I'd really like to know your opinion about this solution. What concerns me the most is:

  • do I use BEM correctly?
  • is the website accessible?
  • is the file structure within the SCSS folder readable?

  Thank you in advance for your feedback!

  

  Pure html, css and js, using SCSS and BEM

  3

  3

  2

  

  Hoe Hooi Yan• 285

  @hoehooiyan

  Posted about 4 years ago

  Hey there, your solution looks nice! Only a little adjustment to be made and it would be the same as the design.

  1. I just reviewed your code. The BEM usage is correct 👍

  2. For the accessibility report, I can see that there are 3 errors which are about the anchor tag problem, maybe it's because the provided link is not correct. You may need to write it like so href="https://www.facebook.com"

  3. The SCSS folder structure would be better if you group those same elements inside the same folder. Or you may follow the 7-1 architecture

  • base
  • abstracts
  • components
  • themes
  • pages
  • vendors
  • layouts

  The 7-1 architecture would be useful when we are doing a larger project.

  2