Skip to content
OverviewSolutions
25
Comments
6
P

Isaac Novaes

@isaacnovaesPoland650 points

I’m a mysterious individual who has yet to fill out my bio. One thing’s for certain: I love writing front-end code!

Latest solutions

View more solutions

Latest comments

  • P
    Isaac Novaes•650
    @isaacnovaes

    Hey @danielden!

    Great job! Your solution looks great. Also, the idea of displaying the country's weather and localization is awesome. However, I have a few suggestions:

    • If I go to any country detail and reload the page, your website crashes. I think that you should look into it
    • For a tablet dimension, for example, 811 x 860, all border country buttons are stacked in a column, leaving too much space which could be better used. So fixing it could improve the UI and the responsiveness
    • If a country has no currencies, nothing is displayed. I think that at least a "no currency" message should be displayed
    • If a country has no border, like Antarctica, a UI button with "no countries" text is displayed. I think that only a simple text fits best here instead of a UI button because, in this border countries section, a button links you to another country
    Marked as helpful
  • P
    Isaac Novaes•650
    @isaacnovaes

    Hi @MikevPeeren!

    First of all, thank you for analyzing my solution. About the slider shadow, I just did what the challenge design itself determines.

    Thank you for your considerations! 😁

  • P
    Isaac Novaes•650
    @isaacnovaes

    Hey man!

    Nice job! It looks nice and is responsive. However, I have two suggestions:

    • When you select a country that has many neighboring countries, like Brazil or Germany, their neighboring countries list overflows the screen horizontally for screen widths bigger than 900px. So check it out

    • You could implement a media query for tablets, because from a screen width of 600px to 1000px, the countries flag takes up the majority of the screen, and the countries data looks tiny. So implementing this media query would improve UX

    Marked as helpful
  • P
    Isaac Novaes•650
    @isaacnovaes

    Hello, pikamart!

    First of all, thank you for your feedback, I really appreciate it.

    Here are my comments on your suggestions:

    1. You are totally right because the font rendered was a sans-serif fallback, not the Poppins font. This mistake is already fixed in the new version of the site.

    2. For the mobile version, the text alignment should be center. However, for the desktop version, it should be left. I just forgot to make this conversion. Mistake fixed, too.

    3. Yep, I agree with you. Mistake fixed.

    4. According to the original challenge design, the form inputs should be right-aligned. So I think that my solution is appropriate.

    Once again, thank you for your feedback.

    I ask you to check the new version of my solution. If you find something else, please let me know.

    Happy coding! 😀

  • P
    Isaac Novaes•650
    @isaacnovaes

    Hello Juan,

    On your first main section, an extra scrollbar shows up. I think that overflow:auto; on this section container would fix it.

    Apart from that, nice work!

  • P
    Isaac Novaes•650
    @isaacnovaes

    Hello, Juan!

    First of all, I appreciate your feedback. Thank you man.

    Second of all, I am afraid that I will increase the empty space among the testimonials, because the testimonial container will exceed the global frame of the site, i.e. this increase will break the global pattern margin of the site. In addition, I will increase the vertical space among the sections because I totally agree with you in this point.

    Well, thank you once again 😀